Issue 72360044: code review 72360044: liblink: fix morestack handling on amd64p32.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 72360044: code review 72360044: liblink: fix morestack handling on amd64p32. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by remyoudompheng

Modified:
10 years, 1 month ago

Reviewers:
gobot, rsc, dave

CC:
dave_cheney.net, rsc, iant, golang-codereviews

Visibility:
Public.

Description

liblink: fix morestack handling on amd64p32. It was using MOVL to pass a 64-bit argument (concatenated framesize and argsize) to morestack11.

Patch Set 1 #

Patch Set 2 : diff -r 72b4b258b09b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 72b4b258b09b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 77d8d214820e https://go.googlecode.com/hg/ #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/liblink/obj6.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello dave@cheney.net, rsc@golang.org, iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 1 month ago (2014-03-07 06:41:50 UTC) #1

dave_cheney.net

LGTM, and fixes the issues assembling asm_amd64p32.s in the runtime package. Of course, please wait ...

10 years, 1 month ago (2014-03-07 09:59:50 UTC) #2

remyoudompheng

*** Submitted as https://code.google.com/p/go/source/detail?r=d763454383f4 *** liblink: fix morestack handling on amd64p32. It was using MOVL ...

10 years, 1 month ago (2014-03-07 18:44:40 UTC) #4

gobot

10 years, 1 month ago (2014-03-07 18:53:50 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the openbsd-386-rootbsd builder.

Expand All Messages | Collapse All Messages