Adding Tic-Tac-Toe sample application.

Adding Tic-Tac-Toe sample application.

[dhermes, 2013-01-31 00:52:40]

Changing main page template so it doesn't really on the currently running app.

[dhermes, 2013-01-31 00:53:27]

I meant to say "rely" not "really" in the patch comment.

[dhermes, 2013-01-31 01:09:38]

Indent only change in move towards PEP8.

[danielholevoet, 2013-01-31 01:11:15]

https://codereview.appspot.com/7235069/diff/1011/static/js/base.js
File static/js/base.js (right):

https://codereview.appspot.com/7235069/diff/1011/static/js/base.js#newcode41
static/js/base.js:41: google.devrel.samples.ttt.RESPONSE_TYPE = 'token id_token
gsession';
We can remove gsession.

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py
File tictactoe_api_messages.py (right):

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py#ne...
tictactoe_api_messages.py:8: class ScoreListRequest(messages.Message):
Is convention ScoreList or ScoresList? From the Java side I would think
ScoresList.

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py#ne...
tictactoe_api_messages.py:45: class ScoreIdMessage(messages.Message):
Is this needed if you remove GET?

[dhermes, 2013-01-31 01:19:15]

Method rename only change in move towards PEP8.

[dhermes, 2013-01-31 01:25:54]

Removing score get method, changing message class names to use ScoresList and
removing gsession from JS.

[dhermes, 2013-01-31 01:26:15]

https://codereview.appspot.com/7235069/diff/1011/static/js/base.js
File static/js/base.js (right):

https://codereview.appspot.com/7235069/diff/1011/static/js/base.js#newcode41
static/js/base.js:41: google.devrel.samples.ttt.RESPONSE_TYPE = 'token id_token
gsession';
On 2013/01/31 01:11:15, danielholevoet wrote:
> We can remove gsession.

Done.

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py
File tictactoe_api_messages.py (right):

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py#ne...
tictactoe_api_messages.py:8: class ScoreListRequest(messages.Message):
Changed.

On 2013/01/31 01:11:15, danielholevoet wrote:
> Is convention ScoreList or ScoresList? From the Java side I would think
> ScoresList.

https://codereview.appspot.com/7235069/diff/1011/tictactoe_api_messages.py#ne...
tictactoe_api_messages.py:45: class ScoreIdMessage(messages.Message):
Nope. Removed all.

On 2013/01/31 01:11:15, danielholevoet wrote:
> Is this needed if you remove GET?

[dhermes, 2013-01-31 01:41:58]

Added copyright, some docstrings and removed player from payloads since all
requests require a signed in player.

[dhermes, 2013-01-31 01:55:38]

Finished adding docstrings; finished PEP8 compliance.

[danielholevoet, 2013-01-31 22:53:29]

https://codereview.appspot.com/7235069/diff/6023/models.py
File models.py (right):

https://codereview.appspot.com/7235069/diff/6023/models.py#newcode53
models.py:53: """Model to store scores that have been instered by users.
inserted

https://codereview.appspot.com/7235069/diff/6023/models.py#newcode68
models.py:68: """Turns the Score entity into a ProtoRPC object
missing period

https://codereview.appspot.com/7235069/diff/6023/static/css/base.css
File static/css/base.css (right):

https://codereview.appspot.com/7235069/diff/6023/static/css/base.css#newcode2
static/css/base.css:2: * Copyright 2012 Google Inc. All Rights Reserved.
Replace with Apache 2 boilerplate.

[dhermes, 2013-01-31 23:06:49]

Fixing Apache in css and some docstrings in models.

[danielholevoet, 2013-01-31 23:08:52]

LGTM

[dhermes, 2013-01-31 23:15:18]

Committed in
https://github.com/dhermes/appengine-endpoints-tictactoe-python/commit/36d139...

https://codereview.appspot.com/7235069/diff/6023/models.py
File models.py (right):

https://codereview.appspot.com/7235069/diff/6023/models.py#newcode53
models.py:53: """Model to store scores that have been instered by users.
On 2013/01/31 22:53:30, danielholevoet wrote:
> inserted

Done.

https://codereview.appspot.com/7235069/diff/6023/models.py#newcode68
models.py:68: """Turns the Score entity into a ProtoRPC object
On 2013/01/31 22:53:30, danielholevoet wrote:
> missing period

Done.