Issue 7234048: Correctly count subordinate relations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7234048: Correctly count subordinate relations

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by matthew.scott

Modified:
11 years, 2 months ago

Reviewers:
mp+145217

Visibility:
Public.

Description

Correctly count subordinate relations Subordinate relations were not being properly counted with the new comparison when it came to new services or relations. This was due to object inequality after a component's update method was called. Comparison switched to service modelIds, and test added. https://code.launchpad.net/~makyo/juju-gui/sub-rel-counter-1107999/+merge/145217 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correctly count subordinate relations #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -34 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/relation.js	View		2 chunks	+3 lines, -5 lines	0 comments	Download
M	test/test_environment_view.js	View		4 chunks	+49 lines, -29 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

Land as is. Thanks. https://codereview.appspot.com/7234048/diff/1/app/views/topology/relation.js File app/views/topology/relation.js (right): https://codereview.appspot.com/7234048/diff/1/app/views/topology/relation.js#newcode257 app/views/topology/relation.js:257: vis.selectAll('.service.subordinate') Hurrah for simplicity

11 years, 2 months ago (2013-01-28 21:30:29 UTC) #2

matthew.scott

11 years, 2 months ago (2013-01-29 14:57:45 UTC) #4

*** Submitted:

Correctly count subordinate relations

Subordinate relations were not being properly counted with the new comparison
when it came to new services or relations.  This was due to object inequality
after a component's update method was called.  Comparison switched to service
modelIds, and test added.

R=bac, teknico
CC=
https://codereview.appspot.com/7234048

Expand All Messages | Collapse All Messages