Issue 7228072: code review 7228072: crypto/x509: test for negative RSA parameters.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7228072: code review 7228072: crypto/x509: test for negative RSA parameters. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by agl1

Modified:
11 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

crypto/x509: test for negative RSA parameters. Someone found software that generates negative numbers for the RSA modulus in an X.509 certificate. Our error messages were very poor in this case so this change improves that. Update issue 4728 Return more helpful errors when RSA parameters are negative or zero.

Patch Set 1 #

Patch Set 2 : diff -r 3bd3cbecadd8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 3bd3cbecadd8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 58e1987657d6 https://code.google.com/p/go/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	src/pkg/crypto/x509/x509.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 2 months ago (2013-01-31 15:47:48 UTC) #1

agl1

11 years, 2 months ago (2013-01-31 17:54:57 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=b3af92ac5a0c ***

crypto/x509: test for negative RSA parameters.

Someone found software that generates negative numbers for the RSA
modulus in an X.509 certificate. Our error messages were very poor in
this case so this change improves that.

Update issue 4728
Return more helpful errors when RSA parameters are negative or zero.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7228072

Expand All Messages | Collapse All Messages