cmd/status: simplify status

cmd/status: simplify status

Machine IDs are strings now, this makes status simpler.

https://code.launchpad.net/~dave-cheney/juju-core/095-cmd-juju-status-remove-json-workarounds/+merge/144851

(do not edit description out of merge proposal)

[dfc, 2013-01-25 05:38:18]

Please take a look.

[rog, 2013-01-25 17:11:28]

looks reasonable, but i don't see how the change relates to the CL description.

[fwereade, 2013-01-28 10:05:05]

On 2013/01/25 17:11:28, rog wrote:
> looks reasonable, but i don't see how the change relates to the CL
description.

On deeper thought: machine ids being strings is actually an oversight on my
part, and a problem for everyone who depends on juju status output (and there
are such people). We need to fix our ids regardless, and when we do machines
will have int ids once again.

This specific change LGTM though -- is that just because I'm too dumb to see how
id type fits in here?

[dfc, 2013-01-28 10:06:18]

Now that machine ids are strings, we can use the checkError idiom throughout.

On Mon, Jan 28, 2013 at 9:05 PM,  <fwereade@gmail.com> wrote:
> On 2013/01/25 17:11:28, rog wrote:
>>
>> looks reasonable, but i don't see how the change relates to the CL
>
> description.
>
> On deeper thought: machine ids being strings is actually an oversight on
> my part, and a problem for everyone who depends on juju status output
> (and there are such people). We need to fix our ids regardless, and when
> we do machines will have int ids once again.
>
> This specific change LGTM though -- is that just because I'm too dumb to
> see how id type fits in here?
>
> https://codereview.appspot.com/7202054/

[dfc, 2013-01-28 10:07:10]

This change was peeled away from a larger more involved change that I
was doing to the status tests to make it possible to write relation
status tests without wearing out the keys on my keyboard

On Mon, Jan 28, 2013 at 9:06 PM, Dave Cheney <dave@cheney.net> wrote:
> Now that machine ids are strings, we can use the checkError idiom throughout.
>
> On Mon, Jan 28, 2013 at 9:05 PM,  <fwereade@gmail.com> wrote:
>> On 2013/01/25 17:11:28, rog wrote:
>>>
>>> looks reasonable, but i don't see how the change relates to the CL
>>
>> description.
>>
>> On deeper thought: machine ids being strings is actually an oversight on
>> my part, and a problem for everyone who depends on juju status output
>> (and there are such people). We need to fix our ids regardless, and when
>> we do machines will have int ids once again.
>>
>> This specific change LGTM though -- is that just because I'm too dumb to
>> see how id type fits in here?
>>
>> https://codereview.appspot.com/7202054/

[jameinel, 2013-02-13 11:22:30]

The simplification LGTM.

I didn't realize you could do func(otherfunc()) when you have more than one
return value. Good to know about.

[dfc, 2013-02-19 01:42:02]

Yes, it is one of the few pieces of magic.

On Wed, Feb 13, 2013 at 10:22 PM,  <john.meinel@canonical.com> wrote:
> The simplification LGTM.
>
> I didn't realize you could do func(otherfunc()) when you have more than
> one return value. Good to know about.
>
>
> https://codereview.appspot.com/7202054/

[dfc, 2013-02-21 04:26:43]

*** Submitted:

cmd/status: simplify status

Machine IDs are strings now, this makes status simpler.

R=
CC=
https://codereview.appspot.com/7202054