Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(436)

Side by Side Diff: src/pkg/net/accept_linux.go

Issue 7188044: code review 7188044: net: Use accept4() on Linux. (Closed)
Patch Set: diff -r 2da48f86d386 https://code.google.com/p/go Created 11 years, 2 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2013 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file.
4
5 package net
6
7 import (
8 "syscall"
9 )
10
11 var use_accept4 = true
dfc 2013/01/23 06:15:25 Idiomatic Go code uses camel case. Also, this is
12
13 func (fd *netFD) accept(toAddr func(syscall.Sockaddr) Addr) (netfd *netFD, err e rror) {
14 if err := fd.incref(false); err != nil {
15 return nil, err
16 }
17 defer fd.decref()
18
19 // See ../syscall/exec_unix.go for description of ForkLock.
20 // It is okay to hold the lock across syscall.Accept
21 // because we have put fd.sysfd into non-blocking mode.
22 var s int
23 var rsa syscall.Sockaddr
24 for {
25 if use_accept4 {
26 s, rsa, err = syscall.Accept4(fd.sysfd, syscall.SOCK_CLO EXEC|syscall.SOCK_NONBLOCK)
27 if err == syscall.ENOSYS {
28 use_accept4 = false
29 continue
30 }
31 } else {
32 syscall.ForkLock.RLock()
33 s, rsa, err = syscall.Accept(fd.sysfd)
34 if err == nil {
35 syscall.CloseOnExec(s)
36 }
37 syscall.ForkLock.RUnlock()
38 }
39 if err != nil {
40 if err == syscall.EAGAIN {
41 if err = fd.pollServer.WaitRead(fd); err == nil {
42 continue
43 }
44 } else if err == syscall.ECONNABORTED {
45 // This means that a socket on the listen queue was closed
46 // before we Accept()ed it; it's a silly error, so try again.
47 continue
48 }
49 return nil, &OpError{"accept", fd.net, fd.laddr, err}
50 }
51 break
52 }
53
54 if !use_accept4 {
55 if err = syscall.SetNonblock(s, true); err != nil {
56 closesocket(s)
57 return nil, err
58 }
59 }
60 netfd = newFD(s, fd.family, fd.sotype, fd.net)
61 lsa, _ := syscall.Getsockname(netfd.sysfd)
62 netfd.setAddr(toAddr(lsa), toAddr(rsa))
63 return netfd, nil
64 }
OLDNEW
« no previous file with comments | « src/pkg/net/accept_bsd.go ('k') | src/pkg/net/fd_unix.go » ('j') | src/pkg/net/sock_posix.go » ('J')

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b