Issue 7182044: Fix charm according to "charm proof"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7182044: Fix charm according to "charm proof"

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by frankban

Modified:
11 years, 3 months ago

Reviewers:
mp+144153

Visibility:
Public.

Description

Fix charm according to "charm proof" Add copyright file and maintainer, and remove "juju" key. Landing Gary's branch. https://code.launchpad.net/~frankban/charms/precise/juju-gui/fix-charm-proof/+merge/144153 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix charm according to "charm proof" #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	copyright	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	metadata.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

frankban

*** Submitted: Fix charm according to "charm proof" Add copyright file and maintainer, and remove ...

11 years, 3 months ago (2013-01-21 16:58:52 UTC) #2

frankban

11 years, 3 months ago (2013-01-21 16:59:58 UTC) #3

Add fixes as per review:
see https://codereview.appspot.com/7131063/

Expand All Messages | Collapse All Messages