Fix ambiguous relation selector

Fix ambiguous relation selector

When there are ambiguous relations clicking 
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in 
http://yuilibrary.com/projects/yui3/ticket/2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event 
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific 
card for adding tests for the relation module.

https://code.launchpad.net/~frankban/juju-gui/bug-1102638-ambigous-relation/+merge/144301

(do not edit description out of merge proposal)

[frankban, 2013-01-22 12:46:15]

Please take a look.

[frankban, 2013-01-22 12:47:17]

On 2013/01/22 12:46:15, frankban wrote:
> Please take a look.

Mentioned YUI documentation can be found here:
http://yuilibrary.com/yui/docs/api/classes/NodeList.html#method_on

[benji, 2013-01-22 13:32:45]

Looks good.

[gary.poster, 2013-01-22 13:58:20]

Great catch, Francesco, thank you. Land with changes. 

Gary

https://codereview.appspot.com/7177050/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7177050/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:640: menu.one('.menu').delegate('click',
function(evt) {
Could you also add a comment about why this is necessary, like your cover
letter?

[frankban, 2013-01-22 14:24:53]

Thanks for the reviews.

Added to this branch a trivial fix for a test failing in trunk.

https://codereview.appspot.com/7177050/diff/1/app/views/topology/relation.js
File app/views/topology/relation.js (right):

https://codereview.appspot.com/7177050/diff/1/app/views/topology/relation.js#...
app/views/topology/relation.js:640: menu.one('.menu').delegate('click',
function(evt) {
On 2013/01/22 13:58:20, gary.poster wrote:
> Could you also add a comment about why this is necessary, like your cover
> letter?

Done.

[frankban, 2013-01-22 14:25:04]

Thanks for the reviews.

Added to this branch a trivial fix for a test failing in trunk.

[frankban, 2013-01-22 14:33:47]

Please take a look.

[frankban, 2013-01-22 14:38:12]

*** Submitted:

Fix ambiguous relation selector

When there are ambiguous relations clicking 
to select one or the other does nothing.
This bug affected only our production server,
devel and debug worked well. This is weird,
and I think we are encountering the strange
behavior described in 
http://yuilibrary.com/projects/yui3/ticket/2532993
or similar: in some situation (e.g. our production
server, where js files are minified/compressed)
using the "on" method on NodeList does not work.
I am confused about the real reason for this bug.
However, the documentation says that we should
avoid using NodeList.on, in favor of using event 
delegation, that is exactly what I did in this
branch. Tests are not included: we have a specific 
card for adding tests for the relation module.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7177050