Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3919)

Issue 7177049: Fix "file not found" error.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by frankban
Modified:
11 years, 2 months ago
Reviewers:
mp+144290
Visibility:
Public.

Description

Fix "file not found" error. If the last stable release does not contain a file, deploying a charm failed with a "file not found" error. We encounter this problem, e.g., while uploading a new release: the release is created in Launchpad, but the file takes a bit before being ready. Now the relevant function tries previous releases before failing. Also fixed a functional test failing because now staging does not require explicit authentication (user and password are provided by the config file). https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1102636-file-not-found/+merge/144290 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix "file not found" error. #

Patch Set 3 : Fix "file not found" error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 1 1 chunk +9 lines, -8 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/deploy.test View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/test_utils.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
11 years, 2 months ago (2013-01-22 11:46:28 UTC) #1
bac
Francesco thanks for the quick turn-around on the branch. Land as is. I was confused ...
11 years, 2 months ago (2013-01-22 12:09:35 UTC) #2
teknico
Land as is. Thanks, nice fix. +1 to bac's comment too.
11 years, 2 months ago (2013-01-22 12:18:24 UTC) #3
frankban
Please take a look.
11 years, 2 months ago (2013-01-22 12:24:48 UTC) #4
frankban
Hi Brad and Nicola, thanks for your reviews, another test run and then I'll land ...
11 years, 2 months ago (2013-01-22 12:26:08 UTC) #5
frankban
11 years, 2 months ago (2013-01-22 12:49:53 UTC) #6
*** Submitted:

Fix "file not found" error.

If the last stable release does not contain
a file, deploying a charm failed with a
"file not found" error. We encounter this 
problem, e.g., while uploading a new release:
the release is created in Launchpad, but the 
file takes a bit before being ready.
Now the relevant function tries previous
releases before failing.
Also fixed a functional test failing because
now staging does not require explicit
authentication (user and password are
provided by the config file).

R=bac, teknico
CC=
https://codereview.appspot.com/7177049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b