Issue 7157044: code review 7157044: crypto/x509: return a better error when we fail to load...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7157044: code review 7157044: crypto/x509: return a better error when we fail to load... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by agl1

Modified:
11 years, 3 months ago

Reviewers:

CC:
golang-dev, mkrautz, rsc

Visibility:
Public.

Description

crypto/x509: return a better error when we fail to load system roots.

Patch Set 1 #

Patch Set 2 : diff -r 7418ae25fbb4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 7418ae25fbb4 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 91ecf40e26ae https://code.google.com/p/go/ #

Patch Set 5 : diff -r 91ecf40e26ae https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -17 lines)			Patch
M	src/pkg/crypto/x509/root_darwin.go	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/x509/root_plan9.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/root_stub.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/crypto/x509/root_unix.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/crypto/x509/root_windows.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/pkg/crypto/x509/verify.go	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/x509/verify_test.go	View	1 2 3	4 chunks	+39 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2013-01-17 20:24:28 UTC) #1

mkrautz

There's an issue with the test on Windows, but other than that this LGTM. https://codereview.appspot.com/7157044/diff/5001/src/pkg/crypto/x509/verify_test.go ...

11 years, 3 months ago (2013-01-18 16:10:19 UTC) #2

agl1

11 years, 3 months ago (2013-01-21 16:28:49 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=d499282de902 ***

crypto/x509: return a better error when we fail to load system roots.

R=golang-dev, krautz, rsc
CC=golang-dev
https://codereview.appspot.com/7157044

https://codereview.appspot.com/7157044/diff/5001/src/pkg/crypto/x509/verify_t...
File src/pkg/crypto/x509/verify_test.go (right):

https://codereview.appspot.com/7157044/diff/5001/src/pkg/crypto/x509/verify_t...
src/pkg/crypto/x509/verify_test.go:252: systemRoots = nil
On 2013/01/18 16:10:19, mkrautz wrote:
> This won't work on Windows where we pass through to systemVerify.
> 
> I think it makes sense sense to just set set systemSkip = true for the test.

Done.

Expand All Messages | Collapse All Messages