Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(606)

Issue 7141062: code review 7141062: cmd/api: sort features (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by ality
Modified:
11 years, 2 months ago
Reviewers:
CC:
golang-dev, minux1, bradfitz
Visibility:
Public.

Description

cmd/api: sort features

Patch Set 1 #

Patch Set 2 : diff -r b14680735334 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b14680735334 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0fcf167dc85f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/cmd/api/goapi.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
ality
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 2 months ago (2013-01-19 08:26:07 UTC) #1
minux1
LGTM. However I don't know why we haven't done this already? Brad?
11 years, 2 months ago (2013-01-19 13:04:18 UTC) #2
bradfitz
LGTM I think like that mode (rarely used) regressed in the most recent big refactor. ...
11 years, 2 months ago (2013-01-19 16:40:07 UTC) #3
ality
11 years, 2 months ago (2013-01-20 06:20:52 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=a5410435a57d ***

cmd/api: sort features

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
https://codereview.appspot.com/7141062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b