Issue 7139050: code review 7139050: scrypt: 2x faster.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7139050: code review 7139050: scrypt: 2x faster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dchest

Modified:
11 years, 3 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

scrypt: 2x faster. Work on uint32 slices instead of bytes. Replace usage of Salsa20/8 from salsa package with the specialized version. benchmark old ns/op new ns/op delta BenchmarkKey 266430525 126657130 -52.46%

Patch Set 1 #

Patch Set 2 : diff -r 66f4c1d3bbc4 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 66f4c1d3bbc4 https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 4 : diff -r 66f4c1d3bbc4 https://code.google.com/p/go.crypto #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+216 lines, -34 lines)			Patch
	M	scrypt/scrypt.go	View	1 2 3	2 chunks	+168 lines, -34 lines	0 comments	Download
	M	scrypt/scrypt_test.go	View	1 2 3	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dchest

Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 3 months ago (2013-01-17 09:34:00 UTC) #1

agl1

LGTM other than one nit. I can fix that when landing if you like. https://codereview.appspot.com/7139050/diff/4001/scrypt/scrypt.go ...

11 years, 3 months ago (2013-01-17 16:25:06 UTC) #2

dchest

Fixed, thanks. https://codereview.appspot.com/7139050/diff/4001/scrypt/scrypt.go File scrypt/scrypt.go (right): https://codereview.appspot.com/7139050/diff/4001/scrypt/scrypt.go#newcode1 scrypt/scrypt.go:1: // Copyright 2012-2013 The Go Authors. All ...

11 years, 3 months ago (2013-01-17 16:34:52 UTC) #3

agl1

11 years, 3 months ago (2013-01-17 16:42:54 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=7eef55bbd51c&repo=crypto ***

scrypt: 2x faster.

Work on uint32 slices instead of bytes.
Replace usage of Salsa20/8 from salsa package with
the specialized version.

benchmark       old ns/op    new ns/op    delta
BenchmarkKey    266430525    126657130  -52.46%

R=agl
CC=golang-dev
https://codereview.appspot.com/7139050

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages