Issue 7133077: Eliminate disconnected controls.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7133077: Eliminate disconnected controls.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by frankban

Modified:
11 years, 3 months ago

Reviewers:
mp+144949

Visibility:
Public.

Description

Eliminate disconnected controls. Command line, Graph view, and Destroy controls at the bottom of the environment are disconnected. This branch removes them, since we have no intention of implementing them now. Also fixed missing rail-x.png in devel server. https://code.launchpad.net/~frankban/juju-gui/bug-1104418-disconnected-controls/+merge/144949 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Eliminate disconnected controls. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -79 lines)			Patch
M	Makefile	View	3 chunks	+5 lines, -3 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	app/assets/images/cmd_icon.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	app/assets/images/view_icon.png	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	app/templates/overview.handlebars	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	app/views/topology/service.js	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	lib/views/stylesheet.less	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/test_environment_view.js	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	undocumented	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

teknico

Land as is. Nice, tests pass (on Chromium, Firefox still breaks), and the interface is ...

11 years, 3 months ago (2013-01-25 14:58:58 UTC) #2

matthew.scott

Land as is. Thanks for the changes (especially the 404)! @teknico: Tests passed for me ...

11 years, 3 months ago (2013-01-25 15:13:24 UTC) #3

teknico

matthew.scott wrote: > @teknico: Tests passed for me on Chrome and FF, not sure > ...

11 years, 3 months ago (2013-01-25 15:15:11 UTC) #4

frankban

11 years, 3 months ago (2013-01-25 15:28:36 UTC) #5

*** Submitted:

Eliminate disconnected controls.

Command line, Graph view, and Destroy controls 
at the bottom of the environment are disconnected.
This branch removes them, since we have no 
intention of implementing them now.

Also fixed missing rail-x.png in devel server.

R=teknico, matthew.scott
CC=
https://codereview.appspot.com/7133077

Expand All Messages | Collapse All Messages