Juju GUI source as env var + Charm test branch

Juju GUI source as env var + Charm test branch

This branch introduces the possibility to provide
the Juju GUI source (used in tests) by setting an
environment variable. This way the charm tests can
be run as part of the release qa process, e.g.:

$ JUJU_GUI_SOURCE=lp:mybranch jitsu test juju-gui ...

or, to test a new trunk release:

$ JUJU_GUI_SOURCE=trunk jitsu test juju-gui ...

Also updated the test exercising the process of 
making a release from a branch, i.e. when the
juju-gui-source option points to a Bazaar branch.

Now the branch used is a customized one, present in
`lp:~frankban/juju-gui/charm-tests-branch` (please 
feel free to suggest another, more sane, location, 
and please take a look at that as part of your reviews).
This is a test branch containing only a minimal
Makefile and a release tarball. There, `make distfile`
is almost a no-op, and for this reason the charm test
speed is slightly increased (~4 minutes on ec2).
Source: http://bazaar.launchpad.net/~frankban/juju-gui/charm-tests-branch/files

https://code.launchpad.net/~frankban/charms/precise/juju-gui/source-as-env-var/+merge/142948

(do not edit description out of merge proposal)

[frankban, 2013-01-11 16:48:18]

Please take a look.

[gary.poster, 2013-01-11 17:21:56]

Thanks frankban!  Land with changes.  Good stuff.

Gary

https://codereview.appspot.com/7102044/diff/1/HACKING.md
File HACKING.md (right):

https://codereview.appspot.com/7102044/diff/1/HACKING.md#newcode104
HACKING.md:104: 
Maybe mention the purpose?

"This can be useful to verify that a given branch works with the charm, which is
one of the tasks that release QA should include."

Something like that anyway. :-/

https://codereview.appspot.com/7102044/diff/1/tests/deploy.test
File tests/deploy.test (right):

https://codereview.appspot.com/7102044/diff/1/tests/deploy.test#newcode17
tests/deploy.test:17: JUJU_GUI_TEST_BRANCH =
'lp:~frankban/juju-gui/charm-tests-branch'
I suggest lp:~juju-gui/juju-gui/charm-tests-branch .  You should have privileges
to make this.

[teknico, 2013-01-11 17:41:06]

Land as is (after taking Gary's comments into account).

https://codereview.appspot.com/7102044/diff/1/revision
File revision (right):

https://codereview.appspot.com/7102044/diff/1/revision#newcode1
revision:1: 21
It's a race. ;-)

[frankban, 2013-01-11 17:41:49]

Thanks for the review Gary.

https://codereview.appspot.com/7102044/diff/1/HACKING.md
File HACKING.md (right):

https://codereview.appspot.com/7102044/diff/1/HACKING.md#newcode104
HACKING.md:104: 
On 2013/01/11 17:21:56, gary.poster wrote:
> Maybe mention the purpose?
> 
> "This can be useful to verify that a given branch works with the charm, which
is
> one of the tasks that release QA should include."
> 
> Something like that anyway. :-/

Done.

https://codereview.appspot.com/7102044/diff/1/tests/deploy.test
File tests/deploy.test (right):

https://codereview.appspot.com/7102044/diff/1/tests/deploy.test#newcode17
tests/deploy.test:17: JUJU_GUI_TEST_BRANCH =
'lp:~frankban/juju-gui/charm-tests-branch'
On 2013/01/11 17:21:56, gary.poster wrote:
> I suggest lp:~juju-gui/juju-gui/charm-tests-branch .  You should have
privileges
> to make this.

Done.

[frankban, 2013-01-11 17:42:23]

On 2013/01/11 17:41:06, teknico wrote:
> Land as is (after taking Gary's comments into account).
> 
> https://codereview.appspot.com/7102044/diff/1/revision
> File revision (right):
> 
> https://codereview.appspot.com/7102044/diff/1/revision#newcode1
> revision:1: 21
> It's a race. ;-)

:-D
Thank you.

[frankban, 2013-01-11 18:00:58]

Please take a look.

[frankban, 2013-01-11 18:02:54]

*** Submitted:

Juju GUI source as env var + Charm test branch

This branch introduces the possibility to provide
the Juju GUI source (used in tests) by setting an
environment variable. This way the charm tests can
be run as part of the release qa process, e.g.:

$ JUJU_GUI_SOURCE=lp:mybranch jitsu test juju-gui ...

or, to test a new trunk release:

$ JUJU_GUI_SOURCE=trunk jitsu test juju-gui ...

Also updated the test exercising the process of 
making a release from a branch, i.e. when the
juju-gui-source option points to a Bazaar branch.

Now the branch used is a customized one, present in
`lp:~frankban/juju-gui/charm-tests-branch` (please 
feel free to suggest another, more sane, location, 
and please take a look at that as part of your reviews).
This is a test branch containing only a minimal
Makefile and a release tarball. There, `make distfile`
is almost a no-op, and for this reason the charm test
speed is slightly increased (~4 minutes on ec2).
Source: http://bazaar.launchpad.net/~frankban/juju-gui/charm-tests-branch/files

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7102044