Issue 710041: Update stressapptest to 1.0.2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 710041: Update stressapptest to 1.0.2

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 1 month ago by nsanders

Modified:
5 years, 6 months ago

Reviewers:
petkov

Visibility:
Public.

Description

Update stressapptest to 1.0.2 from http://stressapptest.googlecode.com/files/stressapptest-1.0.2_autoconf.tar.gz Add libaio deps, better comments.

Patch Set 1 #

Total comments: 1

Created: 14 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -3 lines)			Patch
M	client/site_tests/hardware_SAT/hardware_SAT.py	View	2 chunks	+13 lines, -4 lines	1 comment	Download
	client/site_tests/hardware_SAT/stressapptest-1.0.1_autoconf.tar.gz	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	client/site_tests/hardware_SAT/stressapptest-1.0.2_autoconf.tar.gz	View	Binary file		0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

petkov

14 years, 1 month ago (2010-03-24 00:29:37 UTC) #2

LGTM

http://codereview.appspot.com/710041/diff/1/2
File client/site_tests/hardware_SAT/hardware_SAT.py (right):

http://codereview.appspot.com/710041/diff/1/2#newcode36
client/site_tests/hardware_SAT/hardware_SAT.py:36: # ./configure stores relevant
path and environment variables.
Once this is pushed, we should change SAT to use configure from utils and not
read CBUILD/CHOST directly: http://codereview.chromium.org/1161005

Expand All Messages | Collapse All Messages