Issue 166 (OAuth) - GenericData: chainable set method

Issue 166 (OAuth) - GenericData: chainable set method
Based on the HTTP issue - https://codereview.appspot.com/7098052

[yanivi, 2013-01-14 22:02:50]

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/AbstractOAuthGetToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/AbstractOAuthGetToken.java:89:
public AbstractOAuthGetToken set(String fieldName, Object value) {
I know this is going to sound weird, but please don't bother updating anything
for OAuth 1.0.  There are a ton of changes needed to the style for it, but all
of our focus is on OAuth 2.0 right now.

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetAccessToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetAccessToken.java:61:
public OAuthGetAccessToken set(String fieldName, Object value) {
don't update this file because it is OAuth 1.0

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetTemporaryToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetTemporaryToken.java:54:
public OAuthGetTemporaryToken set(String fieldName, Object value) {
don't update this file because it is OAuth 1.0

[yanivi, 2013-01-14 22:13:19]

Please hg pull -u

add set method to:

google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/ClientCredentialsTokenRequest.java

and

google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/PasswordTokenRequest.java

[peleyal, 2013-01-14 22:44:19]

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/AbstractOAuthGetToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/AbstractOAuthGetToken.java:89:
public AbstractOAuthGetToken set(String fieldName, Object value) {
I reverted that change
On 2013/01/14 22:02:50, yanivi wrote:
> I know this is going to sound weird, but please don't bother updating anything
> for OAuth 1.0.  There are a ton of changes needed to the style for it, but all
> of our focus is on OAuth 2.0 right now.

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetAccessToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetAccessToken.java:61:
public OAuthGetAccessToken set(String fieldName, Object value) {
On 2013/01/14 22:02:50, yanivi wrote:
> don't update this file because it is OAuth 1.0

Done.

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
File
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetTemporaryToken.java
(right):

https://codereview.appspot.com/7095052/diff/1/google-oauth-client/src/main/ja...
google-oauth-client/src/main/java/com/google/api/client/auth/oauth/OAuthGetTemporaryToken.java:54:
public OAuthGetTemporaryToken set(String fieldName, Object value) {
On 2013/01/14 22:02:50, yanivi wrote:
> don't update this file because it is OAuth 1.0

Done.

[yanivi, 2013-01-14 22:52:07]

LGTM

[snnn, 2013-05-27 03:15:39]

On 2013/01/14 22:52:07, yanivi wrote:
> LGTM

Why the set method of
com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl returns an
AuthorizationCodeRequestUrl ?

I got such an Exception:

java.lang.ClassCastException:
com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl cannot be cast to
com.google.api.client.auth.oauth2.AuthorizationCodeRequestUrl
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:222)
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:58)
	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:182)
	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:96)
	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:153)
	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:117)
	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:106)
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.<init>(AuthorizationCodeResponseUrl.java:99)
	com.google.api.client.extensions.servlet.auth.oauth2.AbstractAuthorizationCodeCallbackServlet.doGet(AbstractAuthorizationCodeCallbackServlet.java:115)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:728)

I wonder if the exception is related to this code change.

[yanivi, 2013-05-28 11:52:54]

On 2013/05/27 03:15:39, snnn wrote:
> On 2013/01/14 22:52:07, yanivi wrote:
> > LGTM
> 
> Why the set method of
> com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl returns an
> AuthorizationCodeRequestUrl ?
> 
> I got such an Exception:
> 
> java.lang.ClassCastException:
> com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl cannot be cast
to
> com.google.api.client.auth.oauth2.AuthorizationCodeRequestUrl
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:222)
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:58)
> 	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:182)
> 	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:96)
> 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:153)
> 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:117)
> 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:106)
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.<init>(AuthorizationCodeResponseUrl.java:99)
>
	com.google.api.client.extensions.servlet.auth.oauth2.AbstractAuthorizationCodeCallbackServlet.doGet(AbstractAuthorizationCodeCallbackServlet.java:115)
> 	javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
> 	javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
> 
> I wonder if the exception is related to this code change.

Yes, good catch.  Eyal, can you please fix this for 1.15.1?

[peleyal, 2013-05-28 13:10:48]

On 2013/05/28 11:52:54, yanivi wrote:
> On 2013/05/27 03:15:39, snnn wrote:
> > On 2013/01/14 22:52:07, yanivi wrote:
> > > LGTM
> > 
> > Why the set method of
> > com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl returns an
> > AuthorizationCodeRequestUrl ?
> > 
> > I got such an Exception:
> > 
> > java.lang.ClassCastException:
> > com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl cannot be
cast
> to
> > com.google.api.client.auth.oauth2.AuthorizationCodeRequestUrl
> >
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:222)
> >
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.set(AuthorizationCodeResponseUrl.java:58)
> >
	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:182)
> > 	com.google.api.client.http.UrlEncodedParser.parse(UrlEncodedParser.java:96)
> > 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:153)
> > 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:117)
> > 	com.google.api.client.http.GenericUrl.<init>(GenericUrl.java:106)
> >
>
	com.google.api.client.auth.oauth2.AuthorizationCodeResponseUrl.<init>(AuthorizationCodeResponseUrl.java:99)
> >
>
	com.google.api.client.extensions.servlet.auth.oauth2.AbstractAuthorizationCodeCallbackServlet.doGet(AbstractAuthorizationCodeCallbackServlet.java:115)
> > 	javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
> > 	javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
> > 
> > I wonder if the exception is related to this code change.
> 
> Yes, good catch.  Eyal, can you please fix this for 1.15.1?

Take a look in this fix CL - https://codereview.appspot.com/9782046/