Issue 7093062: Allow user and password to be set in config.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7093062: Allow user and password to be set in config.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bac

Modified:
11 years, 3 months ago

Reviewers:
mp+143179

Visibility:
Public.

Description

Allow user and password to be set in config. If the user and password are set in the config files then they will be used and the user will not be prompted. The credentials are set in config-debug.js but not config-prod.js by default. https://code.launchpad.net/~bac/juju-gui/userpass/+merge/143179 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Allow user and password to be set in config. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	app/config-debug.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	app/config-prod.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test_app.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

11 years, 3 months ago (2013-01-14 21:02:25 UTC) #4

*** Submitted:

Allow user and password to be set in config.

If the user and password are set in the config files then they will be used
and the user will not be prompted.

The credentials are set in config-debug.js but not config-prod.js by default.

R=benji, gary.poster
CC=
https://codereview.appspot.com/7093062

Expand All Messages | Collapse All Messages