Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1317)

Issue 7086062: code review 7086062: all: prepend #__USER_LABEL_PREFIX__ to mangled Go symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by minux1
Modified:
11 years, 2 months ago
Reviewers:
CC:
iant, gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

all: prepend #__USER_LABEL_PREFIX__ to mangled Go symbols For old-fashioned Darwin.

Patch Set 1 #

Patch Set 2 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 4 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 5 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 6 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 7 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 8 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Patch Set 9 : diff -r cbf555d07453 https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -116 lines) Patch
M libgo/go/bytes/indexbyte.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M libgo/go/log/syslog/syslog_c.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/go/sync/atomic/atomic.c View 1 2 23 chunks +25 lines, -23 lines 0 comments Download
M libgo/go/sync/cas.c View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M libgo/go/syscall/errno.c View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M libgo/go/syscall/signame.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/go/syscall/wait.c View 1 2 3 4 5 6 7 9 chunks +11 lines, -9 lines 0 comments Download
M libgo/runtime/chan.c View 1 14 chunks +14 lines, -14 lines 0 comments Download
M libgo/runtime/cpuprof.c View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M libgo/runtime/env_posix.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-breakpoint.c View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M libgo/runtime/go-caller.c View 1 2 chunks +3 lines, -3 lines 0 comments Download
M libgo/runtime/go-callers.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-cgo.c View 1 3 chunks +6 lines, -6 lines 0 comments Download
M libgo/runtime/go-fieldtrack.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-getgoroot.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-now.c View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M libgo/runtime/go-reflect-map.c View 1 7 chunks +7 lines, -7 lines 0 comments Download
M libgo/runtime/go-setenv.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-signal.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-typestring.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-unsafe-new.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-unsafe-newarray.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/go-unsafe-pointer.c View 1 2 chunks +2 lines, -2 lines 0 comments Download
M libgo/runtime/goc2c.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/lfstack.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/malloc.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/malloc.goc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M libgo/runtime/mgc0.c View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/mprof.goc View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/panic.c View 1 1 chunk +1 line, -1 line 0 comments Download
M libgo/runtime/parfor.c View 1 3 chunks +3 lines, -3 lines 0 comments Download
M libgo/runtime/proc.c View 1 6 chunks +7 lines, -7 lines 0 comments Download
M libgo/runtime/runtime.h View 1 7 chunks +14 lines, -10 lines 0 comments Download
M libgo/runtime/runtime.c View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend/
11 years, 2 months ago (2013-01-21 03:46:35 UTC) #1
iant
LGTM
11 years, 2 months ago (2013-01-24 19:43:19 UTC) #2
iant
LGTM
11 years, 2 months ago (2013-01-24 19:43:19 UTC) #3
iant
11 years, 2 months ago (2013-01-24 19:43:49 UTC) #4
*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=b8ae4def7c14 ***

all: prepend #__USER_LABEL_PREFIX__ to mangled Go symbols
For old-fashioned Darwin.

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/7086062

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b