Issue 7086059: code review 7086059: goauth2: fix expiration handling when receiving URL-enc...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7086059: code review 7086059: goauth2: fix expiration handling when receiving URL-enc...

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bill.neubauer

Modified:
10 years, 9 months ago

Reviewers:
adg

CC:
golang-dev, adg

Visibility:
Public.

Description

goauth2: fix expiration handling when receiving URL-encoded tokens.

Patch Set 1 #

Patch Set 2 : diff -r b3e86ec424d3 http://code.google.com/p/goauth2/ #

Patch Set 3 : diff -r b3e86ec424d3 http://code.google.com/p/goauth2/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	oauth/oauth.go	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
	M	oauth/oauth_test.go	View	1	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bill.neubauer

Hello golang-dev@googlegroups.com, I'd like you to review this change to http://code.google.com/p/goauth2/

11 years, 3 months ago (2013-01-20 08:34:27 UTC) #1

adg

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=b8ebf16ab80d *** goauth2: fix expiration handling when receiving URL-encoded tokens. R=golang-dev, adg ...

11 years, 3 months ago (2013-01-21 00:07:21 UTC) #3

R=close

Expand All Messages | Collapse All Messages