Issue 7085057: Add tests for new viewport module.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7085057: Add tests for new viewport module.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by bac

Modified:
11 years, 3 months ago

Reviewers:
mp+143120

Visibility:
Public.

Description

Add tests for new viewport module. Add tests for the new module. Also removed an unused function. It looked useful but I didn't think it should hang around if not called. Ben might have had a plan for it. https://code.launchpad.net/~bac/juju-gui/1083933/+merge/143120 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Add tests for new viewport module. #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -14 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/views/topology/viewport.js	View		2 chunks	+1 line, -14 lines	0 comments	Download
M	test/index.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	test/test_viewport_module.js	View		1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

11 years, 3 months ago (2013-01-14 20:30:07 UTC) #4

*** Submitted:

Add tests for new viewport module.

Add tests for the new module.  Also removed an unused function.  It looked
useful but I didn't think it should hang around if not called.  Ben might have
had a plan for it.

R=matthew.scott, benji
CC=
https://codereview.appspot.com/7085057

Expand All Messages | Collapse All Messages