Pending relation from click-to-add-relation fix

Pending relation from click-to-add-relation fix

The pending relation line was not following the cursor or behaving properly when a relation was being added via the service menu.  Conditions were added to the test on this behavior to ensure that mousemove was being called/fired properly.

https://code.launchpad.net/~makyo/juju-gui/clickrel-1097871/+merge/142809

(do not edit description out of merge proposal)

[matthew.scott, 2013-01-10 22:49:47]

Please take a look.

[bac, 2013-01-11 13:00:51]

Hi Matt,

The changes you made look good but you've missed something.  When I choose
'Build relation' I still see a horizontal line shooting off the screen to the
west.  When I move the mouse the relation line hooks up and then tracks the
mouse.

Isn't it possible invoke the same handler when the relation is first requested
so that it immediately draws to the current mouse position?

Re-review requested.

https://codereview.appspot.com/7081043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/7081043/diff/1/app/views/topology/service.js#n...
app/views/topology/service.js:214: 
I guess I'll never understand our linter or indentation rules.  Why 8?  I know
it makes the linter happy...

https://codereview.appspot.com/7081043/diff/1/test/test_environment_view.js
File test/test_environment_view.js (right):

https://codereview.appspot.com/7081043/diff/1/test/test_environment_view.js#n...
test/test_environment_view.js:445: sm.service_click_actions.toggleControlPanel(
Personally, I love this blank line.  I think it serves a great purpose.  It
makes the code more readable.

But under our new rules it is not allowed, unless you put in a comment.

(Just leave it as is.  I won't tell.)

[matthew.scott, 2013-01-11 15:21:16]

Good catch on the start - in testing I found I was leaving my finger on the
touch pad (my setup has a touchpad offset at an angle to keep my wrist happy),
so the cursor was moving enough that I didn't notice.  Switching away from that,
I found the issue: the mouse wasn't on the rect, it was still technically on the
Add Relation button, so coordinates were way off.  Reordering and then calling
the mousemove positioning function fixed it.  Thank you!

https://codereview.appspot.com/7081043/diff/1/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/7081043/diff/1/app/views/topology/service.js#n...
app/views/topology/service.js:214: 
On 2013/01/11 13:00:51, bac wrote:
> I guess I'll never understand our linter or indentation rules.  Why 8?  I know
> it makes the linter happy...

No clue what happened here.  I fixed it, ran make prep, and it was suddently
happy with the four spaces.  Argh.  Oh well, current style suggests that these
should each be their own var declaration, so...

[matthew.scott, 2013-01-11 15:23:31]

Please take a look.

[bac, 2013-01-11 18:18:42]

Works great now Matt.  Thanks for the fix.  Land away.

[bcsaller, 2013-01-11 21:29:48]

LGTM

[matthew.scott, 2013-01-11 22:37:55]

*** Submitted:

Pending relation from click-to-add-relation fix

The pending relation line was not following the cursor or behaving properly when
a relation was being added via the service menu.  Conditions were added to the
test on this behavior to ensure that mousemove was being called/fired properly.

R=bac, bcsaller
CC=
https://codereview.appspot.com/7081043