Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1080)

Issue 7069049: code review 7069049: go/parser: better error message for declaration error (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by gri
Modified:
11 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/parser: better error message for declaration error Fixes issue 4616.

Patch Set 1 #

Patch Set 2 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 3 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 4 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 5 : diff -r e340e2e8fd26 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/go/parser/parser.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/parser/short_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 2 months ago (2013-01-07 19:05:52 UTC) #1
rsc
LGTM
11 years, 2 months ago (2013-01-09 18:50:54 UTC) #2
gri
11 years, 2 months ago (2013-01-09 19:31:59 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=b1d5c6d99533 ***

go/parser: better error message for declaration error

Fixes issue 4616.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7069049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b