Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 7064052: code review 7064052: doc: Mention godoc's handling of example functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by mdempsky
Modified:
9 years, 11 months ago
Reviewers:
CC:
iant, adg, golang-dev
Visibility:
Public.

Description

doc: Mention godoc's handling of example functions. Fixes issue 4625.

Patch Set 1 #

Patch Set 2 : diff -r 8906cf341c9b https://code.google.com/p/go #

Patch Set 3 : diff -r 8906cf341c9b https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r 8906cf341c9b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M doc/articles/godoc_documenting_go_code.html View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mdempsky
Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 11 months ago (2013-01-07 19:13:34 UTC) #1
adg
https://codereview.appspot.com/7064052/diff/5001/doc/articles/godoc_documenting_go_code.html File doc/articles/godoc_documenting_go_code.html (right): https://codereview.appspot.com/7064052/diff/5001/doc/articles/godoc_documenting_go_code.html#newcode95 doc/articles/godoc_documenting_go_code.html:95: <a href="/pkg/testing/#pkg-overview"><code>testing</code></a> package's naming this paragraph is oddly placed. ...
9 years, 11 months ago (2013-01-08 05:44:41 UTC) #2
mdempsky
https://codereview.appspot.com/7064052/diff/5001/doc/articles/godoc_documenting_go_code.html File doc/articles/godoc_documenting_go_code.html (right): https://codereview.appspot.com/7064052/diff/5001/doc/articles/godoc_documenting_go_code.html#newcode95 doc/articles/godoc_documenting_go_code.html:95: <a href="/pkg/testing/#pkg-overview"><code>testing</code></a> package's naming On 2013/01/08 05:44:41, adg wrote: ...
9 years, 11 months ago (2013-01-08 08:25:40 UTC) #3
mdempsky
Hello iant@golang.org, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 11 months ago (2013-01-08 08:30:08 UTC) #4
iant
LGTM
9 years, 11 months ago (2013-01-09 15:29:15 UTC) #5
iant
9 years, 11 months ago (2013-01-09 15:31:27 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=afa30db15b70 ***

doc: Mention godoc's handling of example functions.

Fixes issue 4625.

R=iant, adg
CC=golang-dev
https://codereview.appspot.com/7064052

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b