Issue 7058063: Break out store and cmd/charm* into lp:juju-store

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7058063: Break out store and cmd/charm* into lp:juju-store (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by allenap

Modified:
10 years, 7 months ago

Reviewers:
mp+142564, fwereade

Visibility:
Public.

Description

Break out store and cmd/charm* into lp:juju-store Red Squad are going to be working on the charm store, and it was suggested that an early task would be to split the charm store out into a separate project. That work has already been done - see lp:juju-store - and this is the clean-up job. mgz helped me a lot in doing both these tasks. Fwiw, juju-store has not been advertised, so feel free to suggest a different name. https://code.launchpad.net/~allenap/juju-core/break-out-juju-store/+merge/142564 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -2600 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	cmd/charmd/config.yaml	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	cmd/charmd/main.go	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	cmd/charmload/config.yaml	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	cmd/charmload/main.go	View	1 chunk	+0 lines, -75 lines	0 comments	Download
D	store/branch.go	View	1 chunk	+0 lines, -152 lines	0 comments	Download
D	store/branch_test.go	View	1 chunk	+0 lines, -238 lines	0 comments	Download
D	store/lpad.go	View	1 chunk	+0 lines, -113 lines	0 comments	Download
D	store/lpad_test.go	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	store/mgo_test.go	View	1 chunk	+0 lines, -95 lines	0 comments	Download
D	store/server.go	View	1 chunk	+0 lines, -191 lines	0 comments	Download
D	store/server_test.go	View	1 chunk	+0 lines, -209 lines	0 comments	Download
D	store/store.go	View	1 chunk	+0 lines, -774 lines	0 comments	Download
D	store/store_test.go	View	1 chunk	+0 lines, -608 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

fwereade

11 years, 3 months ago (2013-01-11 09:17:35 UTC) #2

On 2013/01/09 17:59:58, allenap wrote:
> Please take a look.

LGTM; I'm +1 on juju-store myself.

Expand All Messages | Collapse All Messages