Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(750)

Issue 7054043: Let ChordNameVoice use the same performers as Voice (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dak
Modified:
11 years, 3 months ago
Reviewers:
J. Rohrer, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let ChordNameVoice use the same performers as Voice In particular, ties should be heeded when creating Midi from a ChordNames context as they result in the omission of the engraved chord name if an identical chord follows. Reasoning for beams and slurs is fuzzier, but an articulation different from the same music in a regular Voice context does not seem to make sense.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ly/performer-init.ly View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3
lemzwerg
LGTM. Thanks for the quick fix.
11 years, 3 months ago (2013-01-04 13:56:30 UTC) #1
J. Rohrer
Tested this, specifically to see if \midi { \context { \ChordNameVoice \remove Note_performer } } ...
11 years, 3 months ago (2013-01-04 19:32:02 UTC) #2
dak
11 years, 3 months ago (2013-01-04 19:38:20 UTC) #3
On 2013/01/04 19:32:02, J. Rohrer wrote:

> [Thus I learned something about contexts today: I would not have naively
> expected
> 
>   \context { \AlreadyDefinedContext \name NewContext },
> 
> to actually create a new, independent context, since the command looks more
like
> a tweak on \AlreadyDefinedContext. But obviously this is useful.]

\AlreadyDefinedContext _always_ creates a new, independent context copy.  It is
just that at the end of the context definition, whatever the name ends up to be
is telling the output definition just where to write this new context
definition.  If you don't change the \name, it is going to end up in the place
of the old definition.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b