Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3443)

Issue 7028048: code review 7028048: cmd/8g: extend elimination of temporaries to SSE2 code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by remyoudompheng
Modified:
11 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/8g: extend elimination of temporaries to SSE2 code. Before: (erf.go:188) TEXT Erf+0(SB),$220 (erf.go:265) TEXT Erfc+0(SB),$204 (lgamma.go:174) TEXT Lgamma+0(SB),$948 After: (erf.go:188) TEXT Erf+0(SB),$84 (erf.go:265) TEXT Erfc+0(SB),$84 (lgamma.go:174) TEXT Lgamma+0(SB),$44 SSE before vs. SSE after: benchmark old ns/op new ns/op delta BenchmarkAcosh 81 49 -39.14% BenchmarkAsinh 109 109 +0.00% BenchmarkAtanh 73 74 +0.68% BenchmarkLgamma 138 42 -69.20% BenchmarkModf 24 15 -36.95% BenchmarkSqrtGo 565 556 -1.59%

Patch Set 1 #

Patch Set 2 : diff -r be005b410410 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r be005b410410 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e5d8cdcc49fe https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M src/cmd/8g/reg.c View 1 2 chunks +26 lines, -17 lines 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 2 months ago (2013-01-02 22:18:07 UTC) #1
remyoudompheng
The introduction of the GO386=sse setting caused a performance hit: on a Core 2, GO386=387 ...
11 years, 2 months ago (2013-01-02 22:19:59 UTC) #2
rsc
LGTM
11 years, 2 months ago (2013-01-02 22:22:27 UTC) #3
remyoudompheng
11 years, 2 months ago (2013-01-02 23:44:37 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=6e941dd4ded3 ***

cmd/8g: extend elimination of temporaries to SSE2 code.

Before:
(erf.go:188)    TEXT     Erf+0(SB),$220
(erf.go:265)    TEXT     Erfc+0(SB),$204
(lgamma.go:174) TEXT     Lgamma+0(SB),$948

After:
(erf.go:188)    TEXT     Erf+0(SB),$84
(erf.go:265)    TEXT     Erfc+0(SB),$84
(lgamma.go:174) TEXT     Lgamma+0(SB),$44

SSE before vs. SSE after:

benchmark             old ns/op    new ns/op    delta
BenchmarkAcosh               81           49  -39.14%
BenchmarkAsinh              109          109   +0.00%
BenchmarkAtanh               73           74   +0.68%
BenchmarkLgamma             138           42  -69.20%
BenchmarkModf                24           15  -36.95%
BenchmarkSqrtGo             565          556   -1.59%

R=rsc
CC=golang-dev
https://codereview.appspot.com/7028048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b