Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1509)

Issue 7019044: Report unterminated ties hanging at end of input (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by pkx166h
Modified:
7 years ago
Reviewers:
zefram, dak
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Report unterminated ties hanging at end of input Issue 3062 LP doesn't report unterminated ties that are left hanging at the end of input. Compare { a2~ r2 } (which warns) with { a2~ } (which doesn't). Contrast against the handling of slurs, where both { a2( r2 } and { a2( } warn.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M lily/tie-engraver.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2
pkx166h
Issue 3062 - patch created by 'Zefram', but submitted by James
11 years, 3 months ago (2012-12-26 21:25:20 UTC) #1
pkx166h
11 years, 2 months ago (2013-01-07 21:41:14 UTC) #2
Comment by project member dak@gnu.org, Dec 26, 2012
The regtest tie-whole.ly is written badly, a warning is appropriate.  There is
no point in warning three times, though: once for every note in the chord.

The warnings in quote-tie.log and quote-cue-during.log, however, are
inappropriate.  If one puts slurs where the ties are, this does not generate a
warning without the patch (I have not checked with slurs and this patch), so the
wrong warning for ties by this patch has no previous parallel in slurs, either.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b