Issue 7005050: code review 7005050: cmd/gc: fix race instrumentation of unaddressable arrays.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7005050: code review 7005050: cmd/gc: fix race instrumentation of unaddressable arrays. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by remyoudompheng

Modified:
12 years, 6 months ago

Reviewers:

CC:
dvyukov, golang-dev

Visibility:
Public.

Description

cmd/gc: fix race instrumentation of unaddressable arrays. Fixes issue 4578.

Patch Set 1 #

Patch Set 2 : diff -r 6fdc1974457c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6fdc1974457c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f4e5087c1c19 https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/cmd/gc/racewalk.c	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
	M	src/pkg/runtime/race/testdata/map_test.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

remyoudompheng

Hello dvyukov@google.com, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-12-22 00:05:16 UTC) #1

remyoudompheng

The runtime/race unit tests don't fail when there is a compilation failure (instead it says ...

12 years, 7 months ago (2012-12-22 00:06:21 UTC) #2

dvyukov

On 2012/12/22 00:06:21, remyoudompheng wrote: > The runtime/race unit tests don't fail when there is ...

12 years, 7 months ago (2012-12-24 08:10:13 UTC) #4

remyoudompheng

12 years, 7 months ago (2012-12-24 11:20:49 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=abda9a991753 ***

cmd/gc: fix race instrumentation of unaddressable arrays.

Fixes issue 4578.

R=dvyukov, golang-dev
CC=golang-dev
https://codereview.appspot.com/7005050

Expand All Messages | Collapse All Messages