Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1312)

Issue 7004049: code review 7004049: cmd/5l: support -Z (zero stack frame at function entry) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by minux1
Modified:
11 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

cmd/5l: support -Z (zero stack frame at function entry) also added appropriate docs to cmd/ld/doc.go (largely copied from Russ's CL 6938073).

Patch Set 1 #

Patch Set 2 : diff -r a244dfa507e0 https://code.google.com/p/go #

Patch Set 3 : diff -r bd8499d19a94 https://code.google.com/p/go/ #

Patch Set 4 : diff -r bd8499d19a94 https://code.google.com/p/go/ #

Patch Set 5 : diff -r bd8499d19a94 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 16fa351dc8b6 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 16fa351dc8b6 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M src/cmd/5l/l.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/5l/obj.c View 1 2 3 4 5 1 chunk +6 lines, -1 line 0 comments Download
M src/cmd/5l/pass.c View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download
M src/cmd/ld/doc.go View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3
minux1
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 3 months ago (2012-12-23 19:46:47 UTC) #1
rsc
LGTM
11 years, 3 months ago (2012-12-29 19:23:35 UTC) #2
minux1
11 years, 2 months ago (2013-01-11 04:26:12 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=68ae719b2335 ***

cmd/5l: support -Z (zero stack frame at function entry)
also added appropriate docs to cmd/ld/doc.go
(largely copied from Russ's CL 6938073).

R=rsc
CC=golang-dev
https://codereview.appspot.com/7004049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b