Issue 7002043: code review 7002043: cmd/vet: expand printf flags understood by %s and %q.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7002043: code review 7002043: cmd/vet: expand printf flags understood by %s and %q. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by dsymonds

Modified:
12 years, 7 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

cmd/vet: expand printf flags understood by %s and %q. Fixes issue 4580.

Patch Set 2 : diff -r b9bee6184b4e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b9bee6184b4e https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r b9bee6184b4e https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b9bee6184b4e https://go.googlecode.com/hg/ #

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/cmd/vet/print.go	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 7 months ago (2012-12-21 00:26:01 UTC) #1

adg

https://codereview.appspot.com/7002043/diff/2002/src/cmd/vet/print.go File src/cmd/vet/print.go (right): https://codereview.appspot.com/7002043/diff/2002/src/cmd/vet/print.go#newcode285 src/cmd/vet/print.go:285: fmt.Printf("%08s", "woo") // correct can we get a test ...

12 years, 7 months ago (2012-12-21 01:14:55 UTC) #2

dsymonds

12 years, 7 months ago (2012-12-21 01:53:08 UTC) #3

dsymonds

Hello golang-dev@googlegroups.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 7 months ago (2012-12-21 01:53:23 UTC) #4

dsymonds

12 years, 7 months ago (2012-12-21 02:48:44 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=95aff3fe5362 ***

cmd/vet: expand printf flags understood by %s and %q.

Fixes issue 4580.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/7002043

Expand All Messages | Collapse All Messages