Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 7000051: code review 7000051: encoding/gob: document that structs only encode/decode ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by rsc
Modified:
12 years, 7 months ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

encoding/gob: document that structs only encode/decode exported fields Fixes issue 4579.

Patch Set 1 #

Patch Set 2 : diff -r bf8a8abfad46 https://code.google.com/p/go/ #

Patch Set 3 : diff -r bf8a8abfad46 https://code.google.com/p/go/ #

Patch Set 4 : diff -r bf8a8abfad46 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/pkg/encoding/gob/doc.go View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 7 months ago (2012-12-22 15:32:21 UTC) #1
minux1
LGTM. I think this is common to encoding/* packages, should we write about this in ...
12 years, 7 months ago (2012-12-22 15:36:59 UTC) #2
rsc
I don't think so. That will make it look like there is a package named ...
12 years, 7 months ago (2012-12-22 15:43:31 UTC) #3
rsc
12 years, 7 months ago (2012-12-22 15:43:52 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=535511012f51 ***

encoding/gob: document that structs only encode/decode exported fields

Fixes issue 4579.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/7000051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b