Issue 6998052: code review 6998052: runtime: ignore failure from madvise

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6998052: code review 6998052: runtime: ignore failure from madvise (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by rsc

Modified:
11 years, 3 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

runtime: ignore failure from madvise When we release memory to the OS, if the OS doesn't want us to release it (for example, because the program executed mlockall(MCL_FUTURE)), madvise will fail. Ignore the failure instead of crashing. Fixes issue 3435.

Patch Set 1 #

Patch Set 2 : diff -r 91f2c8a77c8d https://code.google.com/p/go/ #

Patch Set 3 : diff -r 91f2c8a77c8d https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -26 lines)			Patch
M	src/pkg/runtime/sys_darwin_386.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_darwin_amd64.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_386.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_amd64.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_freebsd_arm.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_386.s	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_amd64.s	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/pkg/runtime/sys_linux_arm.s	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/runtime/sys_netbsd_386.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_netbsd_amd64.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/pkg/runtime/sys_openbsd_amd64.s	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2012-12-22 20:06:23 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=21b73dfead26 *** runtime: ignore failure from madvise When we release memory to ...

11 years, 3 months ago (2012-12-22 20:06:30 UTC) #2

Message was sent while issue was closed.

lgtm

Expand All Messages | Collapse All Messages