Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(491)

Issue 69980044: all: add ppc64 as a valid tool arch

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by dfc
Modified:
10 years ago
Reviewers:
mp+208990, axw, wallyworld, fwereade
Visibility:
Public.

Description

all: add ppc64 as a valid tool arch https://code.launchpad.net/~dave-cheney/juju-core/168-ppc-is-people-too/+merge/208990 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: add ppc64 as a valid tool arch #

Total comments: 1

Patch Set 3 : all: add ppc64 as a valid tool arch #

Total comments: 4

Patch Set 4 : all: add ppc64 as a valid tool arch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/plugins/juju-metadata/validatetoolsmetadata.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M constraints/constraints.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M environs/imagemetadata/simplestreams.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M environs/manual/init.go View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M environs/tools/tools.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M instance/instance.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/ec2.go View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M provider/openstack/provider.go View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/release-public-tools/release-public-tools.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
dfc
Please take a look.
10 years ago (2014-03-03 03:18:27 UTC) #1
dfc
Please take a look.
10 years ago (2014-03-03 03:24:19 UTC) #2
wallyworld
LGTM but i'll file a bug to fix the repeated "amd64", "i386", "arm", "arm64 ", ...
10 years ago (2014-03-05 03:07:10 UTC) #3
fwereade
FWIW I love the branch name.
10 years ago (2014-03-07 12:33:21 UTC) #4
dfc
Please take a look.
10 years ago (2014-03-10 02:57:32 UTC) #5
axw
If GOARCH!="ppc64", ubuntuArch in version/version.go needs updating too. Otherwise with these things fixed, LGTM. https://codereview.appspot.com/69980044/diff/10011/cmd/plugins/juju-metadata/validatetoolsmetadata.go ...
10 years ago (2014-03-11 02:39:40 UTC) #6
dfc
On 2014/03/11 02:39:40, axw wrote: > If GOARCH!="ppc64", ubuntuArch in version/version.go needs updating too. > ...
10 years ago (2014-03-11 02:45:03 UTC) #7
dfc
https://codereview.appspot.com/69980044/diff/30001/environs/manual/init.go File environs/manual/init.go (right): https://codereview.appspot.com/69980044/diff/30001/environs/manual/init.go#newcode132 environs/manual/init.go:132: {regexp.MustCompile("ppc64el"), "ppc64"}, On 2014/03/11 02:39:41, axw wrote: > s/el/le/ ...
10 years ago (2014-03-11 05:58:58 UTC) #8
dfc
> https://codereview.appspot.com/69980044/diff/10011/cmd/plugins/juju-metadata/validatetoolsmetadata.go#newcode163 > cmd/plugins/juju-metadata/validatetoolsmetadata.go:163: Architectures: > []string{"amd64", "arm", "i386", "arm64", "ppc64"}, > I'm not so ...
10 years ago (2014-03-11 05:59:43 UTC) #9
dfc
Please take a look.
10 years ago (2014-03-11 06:00:07 UTC) #10
axw
10 years ago (2014-03-11 06:15:11 UTC) #11
On 2014/03/11 05:59:43, dfc wrote:
> >
>
https://codereview.appspot.com/69980044/diff/10011/cmd/plugins/juju-metadata/...
> > cmd/plugins/juju-metadata/validatetoolsmetadata.go:163: Architectures:
> > []string{"amd64", "arm", "i386", "arm64", "ppc64"},
> > I'm not so sure about ppc64. Over on
> > http://cloud-images.ubuntu.com/releases/trusty/beta-1/ it's ppc64el.
> 
> We normalise ppc64el/le to ppc64 as that is the GOARCH that Go knows about.
Same
> as aarch64 -> arm64

Yeah sorry, that was an old comment I forgot to delete. Thanks.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b