Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(743)

Issue 69800043: code review 69800043: [release-branch.go1.2] runtime: if traceback sees a bre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 8 months ago by rsc
Modified:
5 years, 6 months ago
Reviewers:
r, gobot
CC:
golang-codereviews, r, golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change the PC ««« CL 49580044 / 38cd458b1dfe runtime: if traceback sees a breakpoint, don't change the PC Changing the PC confuses gdb, because execution does not continue where gdb expects it. Not changing the PC has the potential to confuse a stack dump, but when running under gdb it seems better to confuse a stack dump than to confuse gdb. Fixes issue 6776. LGTM=rsc R=golang-codereviews, dvyukov, rsc CC=golang-codereviews https://codereview.appspot.com/49580044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 87dea3f5ebe7 https://code.google.com/p/go #

Patch Set 3 : diff -r a3bd976f67c6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/pkg/runtime/sys_x86.c View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
5 years, 8 months ago (2014-02-28 01:45:42 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
5 years, 8 months ago (2014-02-28 01:48:37 UTC) #2
r
LGTM
5 years, 8 months ago (2014-02-28 03:08:59 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=405a8bbea181 *** [release-branch.go1.2] runtime: if traceback sees a breakpoint, don't change the ...
5 years, 8 months ago (2014-02-28 03:43:49 UTC) #4
gobot
This CL appears to have broken the dragonfly-386 builder.
5 years, 8 months ago (2014-02-28 04:20:29 UTC) #5
gobot
This CL appears to have broken the linux-amd64 builder. See http://build.golang.org/log/f485e19c1fd197eea415bec803b1e416517dede0
5 years, 6 months ago (2014-05-21 22:14:11 UTC) #6
rsc
5 years, 6 months ago (2014-05-21 22:58:21 UTC) #7
Message was sent while issue was closed.
On 2014/05/21 22:14:11, gobot wrote:
> This CL appears to have broken the linux-amd64 builder.
> See http://build.golang.org/log/f485e19c1fd197eea415bec803b1e416517dede0

And it only took 11 weeks to find out!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b