Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 6976054: code review 6976054: runtime: diagnose double wakeup on Note (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dvyukov
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

runtime: diagnose double wakeup on Note Double wakeup is prohibited by the Note interface and checked in lock_sema.c.

Patch Set 1 #

Patch Set 2 : diff -r a298f2d529ec https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r a298f2d529ec https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r a298f2d529ec https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 46418dc3d59d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/pkg/runtime/lock_futex.c View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 6 months ago (2012-12-24 16:38:13 UTC) #1
bradfitz
LGTM On Mon, Dec 24, 2012 at 8:38 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
9 years, 6 months ago (2012-12-24 16:56:59 UTC) #2
dvyukov
*** Submitted as https://code.google.com/p/go/source/detail?r=aa5d9f234a8e *** runtime: diagnose double wakeup on Note Double wakeup is prohibited ...
9 years, 6 months ago (2012-12-24 17:07:26 UTC) #3
bradfitz
Dmitri, I just got this crash from this CL at 74e2affcfe39. It went away after ...
9 years, 5 months ago (2013-01-08 20:16:31 UTC) #4
dvyukov
On Wed, Jan 9, 2013 at 12:16 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > Dmitri, > ...
9 years, 5 months ago (2013-01-09 07:00:42 UTC) #5
dvyukov
On Wed, Jan 9, 2013 at 11:00 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Wed, ...
9 years, 5 months ago (2013-01-09 07:22:21 UTC) #6
bradfitz
On Tue, Jan 8, 2013 at 11:00 PM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Wed, ...
9 years, 5 months ago (2013-01-09 22:58:36 UTC) #7
dvyukov
9 years, 5 months ago (2013-01-10 05:55:03 UTC) #8
On Thu, Jan 10, 2013 at 2:58 AM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>> wrote:
>> > Dmitri,
>> >
>> > I just got this crash from this CL at 74e2affcfe39.
>> >
>> > It went away after my next run of "go test -short std", though.  I only
>> > saw
>> > it once:
>> >
>> > fatal error: notewakeup - double wakeup
>>
>>
>> Is it linux?
>
>
> yes
>
>>
>> I guess you don't have local changes in runtime, right?
>
>
> no runtime changes


I will inspect usages of Note, but without knowing what Note it is,
it's unlikely to succeed...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b