Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 6962049: code review 6962049: testing: fix example test fd leak (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by cehessman
Modified:
11 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

testing: fix example test fd leak Close the read side of the pipe. Fixes issue 4551.

Patch Set 1 #

Patch Set 2 : diff -r e7cd0a82d669 https://code.google.com/p/go #

Patch Set 3 : diff -r e7cd0a82d669 https://code.google.com/p/go #

Patch Set 4 : diff -r 41b82b6b2ccd https://code.google.com/p/go #

Patch Set 5 : diff -r 41b82b6b2ccd https://code.google.com/p/go #

Total comments: 1

Patch Set 6 : diff -r a244dfa507e0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/pkg/testing/example.go View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8
cehessman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 3 months ago (2012-12-19 20:51:15 UTC) #1
rsc
LGTM Thanks.
11 years, 3 months ago (2012-12-20 19:19:11 UTC) #2
rsc
It looks like maybe you need to run 'hg update default' to switch to the ...
11 years, 3 months ago (2012-12-20 19:20:26 UTC) #3
cehessman
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2012-12-20 20:54:34 UTC) #4
cehessman
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2012-12-20 20:56:36 UTC) #5
rsc
https://codereview.appspot.com/6962049/diff/14001/src/pkg/testing/example.go File src/pkg/testing/example.go (right): https://codereview.appspot.com/6962049/diff/14001/src/pkg/testing/example.go#newcode48 src/pkg/testing/example.go:48: defer r.Close() I'm sorry I didn't notice this before, ...
11 years, 3 months ago (2012-12-22 15:19:03 UTC) #6
cehessman
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 3 months ago (2012-12-22 16:48:47 UTC) #7
rsc
11 years, 3 months ago (2012-12-22 18:41:06 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=1e5437c42bcc ***

testing: fix example test fd leak

Close the read side of the pipe.
Fixes issue 4551.

R=rsc
CC=golang-dev
https://codereview.appspot.com/6962049

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b