Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(517)

Issue 6948059: code review 6948059: go.crypto/ssh: support OpenSSH keepalives

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by emm
Modified:
10 years, 8 months ago
Reviewers:
agl1
CC:
minux1, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: support OpenSSH keepalives Fixes issue 4552.

Patch Set 1 #

Patch Set 2 : diff -r fa541a5bd620 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 040ebe98531e https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 040ebe98531e https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r 040ebe98531e https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 040ebe98531e https://code.google.com/p/go.crypto #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M ssh/client.go View 1 1 chunk +4 lines, -0 lines 1 comment Download
M ssh/session.go View 1 1 chunk +5 lines, -1 line 0 comments Download
M ssh/session_test.go View 1 2 3 4 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 11
minux1
please add a test.
11 years, 3 months ago (2012-12-15 19:48:50 UTC) #1
emm
On 2012/12/15 19:48:50, minux wrote: > please add a test. Added a test for the ...
11 years, 3 months ago (2012-12-15 22:54:25 UTC) #2
minux1
I think it's ready to be mailed out.
11 years, 3 months ago (2012-12-15 22:56:15 UTC) #3
emm
Hello minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
11 years, 3 months ago (2012-12-15 23:32:19 UTC) #4
agl1
https://codereview.appspot.com/6948059/diff/12001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/6948059/diff/12001/ssh/client.go#newcode313 ssh/client.go:313: if msg.WantReply { Replying with failure seems reasonable if ...
11 years, 3 months ago (2012-12-17 15:08:16 UTC) #5
agl1
p.s. it looks like you need to sign the ICA http://golang.org/doc/contribute.html#copyright
11 years, 3 months ago (2012-12-17 15:10:26 UTC) #6
emm
On 2012/12/17 15:10:26, agl1 wrote: > p.s. it looks like you need to sign the ...
11 years, 3 months ago (2012-12-18 01:31:36 UTC) #7
emm
On 2012/12/17 15:08:16, agl1 wrote: > https://codereview.appspot.com/6948059/diff/12001/ssh/client.go > File ssh/client.go (right): > > https://codereview.appspot.com/6948059/diff/12001/ssh/client.go#newcode313 > ...
11 years, 3 months ago (2012-12-18 01:35:04 UTC) #8
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=f6362ffc5fe8&repo=crypto *** go.crypto/ssh: support OpenSSH keepalives Fixes issue 4552. R=minux.ma, agl CC=golang-dev ...
11 years, 3 months ago (2012-12-18 16:34:16 UTC) #9
agl1
Thanks. I added your reply as a comment in a couple of places.
11 years, 3 months ago (2012-12-18 16:37:12 UTC) #10
remyoudompheng
10 years, 8 months ago (2013-07-21 19:51:05 UTC) #11
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b