Issue 6948057: code review 6948057: go.crypto: gofmt -w -s

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6948057: code review 6948057: go.crypto: gofmt -w -s (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mikio

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Patch Set 2 : diff -r 97169dc936c2 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 97169dc936c2 https://code.google.com/p/go.crypto #

Total comments: 1

Patch Set 4 : diff -r 97169dc936c2 https://code.google.com/p/go.crypto #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	bcrypt/bcrypt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	openpgp/packet/encrypted_key.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	openpgp/packet/private_key.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	openpgp/write_test.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	scrypt/scrypt.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ssh/client_auth.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

11 years, 4 months ago (2012-12-15 04:22:30 UTC) #1

dave_cheney.net

LGTM with one minor. Thank you https://codereview.appspot.com/6948057/diff/4001/openpgp/write_test.go File openpgp/write_test.go (right): https://codereview.appspot.com/6948057/diff/4001/openpgp/write_test.go#newcode190 openpgp/write_test.go:190: md, err := ...

11 years, 4 months ago (2012-12-15 05:05:57 UTC) #2

mikio

On Sat, Dec 15, 2012 at 2:05 PM, <dave@cheney.net> wrote: > openpgp/write_test.go:190: md, err := ...

11 years, 4 months ago (2012-12-15 05:16:46 UTC) #3

mikio

11 years, 4 months ago (2012-12-15 05:19:23 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=fa541a5bd620&repo=crypto ***

go.crypto: gofmt -w -s

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/6948057

Expand All Messages | Collapse All Messages