Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1306)

Issue 6945047: Issue 1029: \thumb should behave like other fingerings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dak
Modified:
11 years, 4 months ago
Reviewers:
Keith, Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 1029: \thumb should behave like other fingerings This changes \thumb from a script to an actual bona-fide fingering. The size tweak is a bit ugly: it might make some sense to resize the actual glyph to match fingerings, but maybe it should then also be relocated from "scripts.thumb".

Patch Set 1 #

Patch Set 2 : Don't tamper with font-size: it messes up \grace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M ly/script-init.ly View 1 1 chunk +3 lines, -1 line 0 comments Download
M scm/script.scm View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3
dak
Don't tamper with font-size: it messes up \grace
11 years, 4 months ago (2012-12-13 17:43:58 UTC) #1
Keith
Should be good. The /total/ height of the glyph matches that of 1-5, without changing ...
11 years, 4 months ago (2012-12-16 04:27:52 UTC) #2
Graham Percival
11 years, 4 months ago (2012-12-20 23:57:59 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b