Issue 6943053: Documentation/GNUmakefile: Add dependencies for internals.texi

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6943053: Documentation/GNUmakefile: Add dependencies for internals.texi (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by J. Rohrer

Modified:
11 years, 3 months ago

Reviewers:
pkx166h

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Documentation/GNUmakefile: Add dependencies for internals.texi The texinfo file internals.texi for the Internals Reference is generated from ly/generate-documentation.ly, which in turn relies on scm/document*.scm and their recursive dependencies to do the actual work. In the process, settings encoded in various other files get documented, e.g. from ly/engraver-init.ly and scm/define-*.scm. Changes to such files do not necessitate, nor trigger, recompiling the LilyPond binary; yet the only dependency marked for internals.texi in Documentation/GNUmakefile was on $(LILYPOND_BINARY). Fix this, for this is obviously inconvenient when hacking the Internals Reference. Rather than tediously maintaining a specific list that grows incomplete whenever the scope of the IR expands, make internals.texi depend on $(INIT_LY_SOURCES) and $(SCHEME_SOURCES) altogether, similar to the rules in make/ly-rules.make.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Documentation/GNUmakefile	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

pkx166h

Johannes, I am not sure if you have push access. If not, send me a ...

11 years, 4 months ago (2012-12-21 07:16:08 UTC) #2

pkx166h

On 2012/12/21 07:16:08, J_lowe wrote: > Johannes, I am not sure if you have push ...

11 years, 3 months ago (2012-12-23 10:49:31 UTC) #3

J. Rohrer

11 years, 3 months ago (2012-12-23 11:04:59 UTC) #4

Message was sent while issue was closed.

On 2012/12/23 10:49:31, J_lowe wrote:
> Pushed
> 
> author Johannes Rohrer <mailto:src@johannesrohrer.de>
>  Sun, 23 Dec 2012 10:41:16 +0000 (10:41 +0000)
> committer James Lowe <mailto:pkx166h@gmail.com>
>  Sun, 23 Dec 2012 10:44:49 +0000 (10:44 +0000)
> commit579622134aba5b4c66068262f9f6ac747f0a66d7
> 
> Please can you close this Rietveld.
> 
> Schönen Dank und Fröhliche Weihnachten

Done.

Thank you, und ebenfalls frohe Weihnachten,

Johannes Rohrer

Expand All Messages | Collapse All Messages