Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(743)

Issue 6940044: lilypond-mode.el: Replace use of obsoleted compile-internal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by dak
Modified:
11 years, 3 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

lilypond-mode.el: Replace use of obsoleted compile-internal In Emacs 24, compile-internal is no longer defined. The respective commit in the Emacs repository (from git mirror) shows: commit 318ea0e29450b3c6e588287719e170e35a978cf7 Author: Chong Yidong <cyd@gnu.org> Date: Mon Sep 24 20:23:25 2012 +0800 Remove several obsolete vars and functions unlikely to be still in use. [...] * lisp/progmodes/compile.el (compile-internal): Remove obsolete function. (compilation-parse-errors-function): Fix typo. [...] -;; This is a rough emulation of the old hack, until the transition to new -;; compile is complete. -(defun compile-internal (command error-message - &optional _name-of-mode parser - error-regexp-alist name-function - _enter-regexp-alist _leave-regexp-alist - file-regexp-alist _nomessage-regexp-alist - _no-async highlight-regexp _local-map) - (if parser - (error "Compile now works very differently, see `compilation-error-regexp - (let ((compilation-error-regexp-alist - (append file-regexp-alist (or error-regexp-alist - compilation-error-regexp-alist))) - (compilation-error (replace-regexp-in-string "^No more \\(.+\\)s\\.?" - "\\1" error-message))) - (compilation-start command nil name-function highlight-regexp))) -(make-obsolete 'compile-internal 'compilation-start "22.1") - I have for now omitted all optional arguments to compilation-start since they are incompatible to previous usage: compilation-start is an autoloaded compiled Lisp function in `compile.el'. (compilation-start COMMAND &optional MODE NAME-FUNCTION HIGHLIGHT-REGEXP) Run compilation command COMMAND (low level interface). If COMMAND starts with a cd command, that becomes the `default-directory'. The rest of the arguments are optional; for them, nil means use the default. MODE is the major mode to set in the compilation buffer. Mode may also be t meaning use `compilation-shell-minor-mode' under `comint-mode'. If NAME-FUNCTION is non-nil, call it with one argument (the mode name) to determine the buffer name. Otherwise, the default is to reuses the current buffer if it has the proper major mode, else use or create a buffer with name based on the major mode. If HIGHLIGHT-REGEXP is non-nil, `next-error' will temporarily highlight the matching section of the visited source line; the default is to use the global value of `compilation-highlight-regexp'. Returns the compilation buffer created.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M elisp/lilypond-mode.el View 1 chunk +3 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b