Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 6932045: code review 6932045: cmd/6g: fix componentgen for funarg structs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by remyoudompheng
Modified:
9 years, 9 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/6g: fix componentgen for funarg structs. Fixes issue 4518.

Patch Set 1 #

Patch Set 2 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ec3ae5b98922 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c2a84616b24e https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M src/cmd/6g/cgen.c View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A test/fixedbugs/issue4518.go View 1 2 3 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 9
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-12-11 07:33:14 UTC) #1
remyoudompheng
This CL will need an appropriate test first. rsc's example looks fine but I tried ...
9 years, 9 months ago (2012-12-11 07:34:49 UTC) #2
rsc
I don't fully understand your mail. Are you saying the CL breaks the example you ...
9 years, 9 months ago (2012-12-11 16:38:24 UTC) #3
remyoudompheng
On 2012/12/11 16:38:24, rsc wrote: > I don't fully understand your mail. Are you saying ...
9 years, 9 months ago (2012-12-11 21:31:47 UTC) #4
remyoudompheng
Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-12-11 21:36:56 UTC) #5
rsc
> Sorry, I meant: I can add a test with your example but it makes ...
9 years, 9 months ago (2012-12-11 22:16:39 UTC) #6
remyoudompheng
Any opinion now?
9 years, 9 months ago (2012-12-14 22:35:11 UTC) #7
rsc
LGTM It makes sense to me now. I was assuming the offset change was due ...
9 years, 9 months ago (2012-12-17 14:56:09 UTC) #8
remyoudompheng
9 years, 9 months ago (2012-12-17 21:37:55 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=0f491e663a44 ***

cmd/6g: fix componentgen for funarg structs.

Fixes issue 4518.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/6932045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b