Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1034)

Issue 6923043: Removes '-signs from vectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by thomasmorley65
Modified:
11 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Removes '-signs from vectors Removes '-signs in vectors from the docs.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Documentation/ly-examples/cary-layout.ily View 1 chunk +8 lines, -8 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/rhythms.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/applying-note-head-styles-depending-on-the-step-of-the-scale.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/preventing-final-mark-from-removing-final-tuplet.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/separating-key-cancellations-from-key-signature-changes.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/bar-number-volta-repeat.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/collision-head-solfa-fa.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/compound-time-signatures.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/easy-notation.ly View 1 chunk +1 line, -1 line 0 comments Download
M input/regression/note-head-solfa.ly View 1 chunk +1 line, -1 line 0 comments Download
M ly/property-init.ly View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6
thomasmorley65
Please review. I didn't touch the translations. Correct? git grep "#'#" returns one file I ...
11 years, 4 months ago (2012-12-11 00:31:04 UTC) #1
dak
On 2012/12/11 00:31:04, thomasmorley65 wrote: > Please review. > > > I didn't touch the ...
11 years, 4 months ago (2012-12-11 05:42:07 UTC) #2
Trevor Daniels
LGTM Trevor
11 years, 4 months ago (2012-12-11 15:13:31 UTC) #3
Graham Percival
LGTM
11 years, 4 months ago (2012-12-16 01:10:45 UTC) #4
janek
LGTM. I suppose that one of David's changes made this patch possible; if you know ...
11 years, 1 month ago (2013-03-27 21:53:39 UTC) #5
dak
11 years, 1 month ago (2013-03-28 06:38:38 UTC) #6
Message was sent while issue was closed.
On 2013/03/27 21:53:39, janek wrote:
> LGTM.
> 
> I suppose that one of David's changes made this patch possible; if you know
> which one it is it would be good to note this (but if you don't know i think
> it's not worth the trouble to search).

No thanks to me: #(1 2 3) always has been the Scheme syntax for literal vectors
without the need of additional quoting.  That's exactly why I considered the
extra quoting in our code base irritating.  Beginners will construct their own
theories of why it is necessary and what it is supposed to mean, and that is not
helping their understanding.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b