Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 6907048: code review 6907048: math/rand: add example / regression test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 5 months ago by rsc
Modified:
9 years, 5 months ago
Reviewers:
corburn, dsymonds
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

math/rand: add example / regression test This makes sure the outputs do not change for a fixed seed. See also https://codereview.appspot.com/6905049.

Patch Set 1 #

Patch Set 2 : diff -r a5efcd1675eb https://code.google.com/p/go/ #

Patch Set 3 : diff -r d636ee0a2861 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
A src/pkg/math/rand/example_test.go View 1 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 5 months ago (2012-12-07 15:13:00 UTC) #1
bradfitz
LGTM On Fri, Dec 7, 2012 at 7:13 AM, <rsc@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
9 years, 5 months ago (2012-12-07 16:30:52 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=477b2e70b12d *** math/rand: add example / regression test This makes sure the ...
9 years, 5 months ago (2012-12-07 16:59:03 UTC) #3
corburn
Typo: Should the Int64 in the second line of this comment be a Int63? // ...
9 years, 5 months ago (2012-12-08 04:19:07 UTC) #4
dsymonds
9 years, 5 months ago (2012-12-08 08:11:34 UTC) #5
On Sat, Dec 8, 2012 at 3:19 PM, Jason Travis <infomaniac7@gmail.com> wrote:

> Typo: Should the Int64 in the second line of this comment be a Int63?

Yes, well spotted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b