Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 6903048: code review 6903048: spec: index and array/slice size constants must fit into int (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by gri
Modified:
9 years, 6 months ago
Reviewers:
CC:
r, rsc, iant, ken2, golang-dev
Visibility:
Public.

Description

spec: index and array/slice size constants must fit into an int

Patch Set 1 #

Patch Set 2 : diff -r 477b2e70b12d https://code.google.com/p/go #

Patch Set 3 : diff -r 477b2e70b12d https://code.google.com/p/go #

Patch Set 4 : diff -r 477b2e70b12d https://code.google.com/p/go #

Patch Set 5 : diff -r 477b2e70b12d https://code.google.com/p/go #

Patch Set 6 : diff -r 67026ef0e79e https://code.google.com/p/go #

Patch Set 7 : diff -r 67026ef0e79e https://code.google.com/p/go #

Patch Set 8 : diff -r 67026ef0e79e https://code.google.com/p/go #

Patch Set 9 : diff -r 67026ef0e79e https://code.google.com/p/go #

Patch Set 10 : diff -r 67026ef0e79e https://code.google.com/p/go #

Total comments: 14

Patch Set 11 : diff -r 67026ef0e79e https://code.google.com/p/go #

Patch Set 12 : diff -r 67026ef0e79e https://code.google.com/p/go #

Total comments: 4

Patch Set 13 : diff -r 0ce7955e8881 https://code.google.com/p/go #

Total comments: 9

Patch Set 14 : diff -r ec3ae5b98922 https://code.google.com/p/go #

Total comments: 2

Patch Set 15 : diff -r f319ec79d278 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M doc/go_spec.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 8 chunks +24 lines, -16 lines 0 comments Download

Messages

Total messages: 20
gri
Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
9 years, 7 months ago (2012-12-07 18:11:35 UTC) #1
gri
Hello r@golang.org, rsc@golang.org, iant@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-12-10 20:24:45 UTC) #2
iant
https://codereview.appspot.com/6903048/diff/18001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18001/doc/go_spec.html#newcode819 doc/go_spec.html:819: negative <a href="#Constants">constant</a> representable by an <code>int</code> value. Perhaps ...
9 years, 6 months ago (2012-12-10 20:36:21 UTC) #3
gri
PTAL https://codereview.appspot.com/6903048/diff/18001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18001/doc/go_spec.html#newcode819 doc/go_spec.html:819: negative <a href="#Constants">constant</a> representable by an <code>int</code> value. ...
9 years, 6 months ago (2012-12-10 21:52:39 UTC) #4
rsc
LGTM except for array size bit https://codereview.appspot.com/6903048/diff/21003/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/21003/doc/go_spec.html#newcode839 doc/go_spec.html:839: array length further, ...
9 years, 6 months ago (2012-12-11 15:53:08 UTC) #5
gri
PTAL https://codereview.appspot.com/6903048/diff/21003/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/21003/doc/go_spec.html#newcode839 doc/go_spec.html:839: array length further, but it must always permit ...
9 years, 6 months ago (2012-12-11 17:49:31 UTC) #6
iant
https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html#newcode840 doc/go_spec.html:840: For instance, the maximum size of an array type ...
9 years, 6 months ago (2012-12-11 18:12:35 UTC) #7
rsc
Ian, do you have any suggestions on the lower bound? In general if the element ...
9 years, 6 months ago (2012-12-11 18:27:44 UTC) #8
gri
I think not setting a lower bound is fine. I added the restriction such that ...
9 years, 6 months ago (2012-12-11 18:31:43 UTC) #9
iant
I still think we should have a lower bound, as we do in our other ...
9 years, 6 months ago (2012-12-11 18:35:30 UTC) #10
r
https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html#newcode820 doc/go_spec.html:820: of type <code>int</code>. "representable by a value of type ...
9 years, 6 months ago (2012-12-11 18:36:30 UTC) #11
rsc
> what is this clause trying to achieve Ian wants to make sure that implementations ...
9 years, 6 months ago (2012-12-11 18:49:54 UTC) #12
gri
No changes but some feedback. https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html#newcode820 doc/go_spec.html:820: of type <code>int</code>. On ...
9 years, 6 months ago (2012-12-11 19:32:55 UTC) #13
iant
FYI https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html#newcode820 doc/go_spec.html:820: of type <code>int</code>. On 2012/12/11 19:32:55, gri wrote: ...
9 years, 6 months ago (2012-12-11 19:50:27 UTC) #14
gri
Specific wording aside, it sounds like everybody is ok with the actual content of the ...
9 years, 6 months ago (2012-12-11 20:02:46 UTC) #15
gri
PTAL. https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/18002/doc/go_spec.html#newcode840 doc/go_spec.html:840: For instance, the maximum size of an array ...
9 years, 6 months ago (2012-12-12 06:46:05 UTC) #16
iant
LGTM
9 years, 6 months ago (2012-12-12 14:47:35 UTC) #17
r
LGTM we can do the wording pedantry separately https://codereview.appspot.com/6903048/diff/19004/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/19004/doc/go_spec.html#newcode820 doc/go_spec.html:820: of ...
9 years, 6 months ago (2012-12-12 17:39:40 UTC) #18
gri
https://codereview.appspot.com/6903048/diff/19004/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6903048/diff/19004/doc/go_spec.html#newcode820 doc/go_spec.html:820: of type <code>int</code>. On 2012/12/12 17:39:40, r wrote: > ...
9 years, 6 months ago (2012-12-12 19:02:45 UTC) #19
gri
9 years, 6 months ago (2012-12-12 19:06:30 UTC) #20
*** Submitted as https://code.google.com/p/go/source/detail?r=614c33a2ccd2 ***

spec: index and array/slice size constants must fit into an int

R=r, rsc, iant, ken
CC=golang-dev
https://codereview.appspot.com/6903048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b