Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6902064: code review 6902064: cmd/[568]g: recycle ONAME nodes used in regopt to denot... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by remyoudompheng
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

cmd/[568]g: recycle ONAME nodes used in regopt to denote registers. The reported decrease in memory usage is about 5%.

Patch Set 1 #

Patch Set 2 : diff -r 6b602ab487d6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M src/cmd/5g/reg.c View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M src/cmd/6g/reg.c View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M src/cmd/8g/reg.c View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5
dfc
Implementing this change on 5g gave a 4mb reduction while compiling pkg/net, 95mb -> 91mb.
9 years, 6 months ago (2012-12-08 23:51:10 UTC) #1
remyoudompheng
Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 6 months ago (2012-12-09 09:29:17 UTC) #2
dfc
LGTM on arm, pkg/net went from 95mb to 91mb with this patch. https://codereview.appspot.com/6902064/diff/5001/src/cmd/5g/reg.c File src/cmd/5g/reg.c ...
9 years, 6 months ago (2012-12-09 09:53:02 UTC) #3
rsc
LGTM
9 years, 6 months ago (2012-12-09 10:28:55 UTC) #4
remyoudompheng
9 years, 6 months ago (2012-12-09 18:11:11 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=df7e014db4cc ***

cmd/[568]g: recycle ONAME nodes used in regopt to denote registers.

The reported decrease in memory usage is about 5%.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/6902064
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b