Issue 6902064: code review 6902064: cmd/[568]g: recycle ONAME nodes used in regopt to denot...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6902064: code review 6902064: cmd/[568]g: recycle ONAME nodes used in regopt to denot... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by remyoudompheng

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

cmd/[568]g: recycle ONAME nodes used in regopt to denote registers. The reported decrease in memory usage is about 5%.

Patch Set 1 #

Patch Set 2 : diff -r 6b602ab487d6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ea15e7ed6d72 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
M	src/cmd/5g/reg.c	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/cmd/6g/reg.c	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1 2	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Implementing this change on 5g gave a 4mb reduction while compiling pkg/net, 95mb -> 91mb.

11 years, 4 months ago (2012-12-08 23:51:10 UTC) #1

remyoudompheng

Hello golang-dev@googlegroups.com, dave@cheney.net (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-12-09 09:29:17 UTC) #2

dave_cheney.net

LGTM on arm, pkg/net went from 95mb to 91mb with this patch. https://codereview.appspot.com/6902064/diff/5001/src/cmd/5g/reg.c File src/cmd/5g/reg.c ...

11 years, 4 months ago (2012-12-09 09:53:02 UTC) #3

remyoudompheng

11 years, 4 months ago (2012-12-09 18:11:11 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=df7e014db4cc ***

cmd/[568]g: recycle ONAME nodes used in regopt to denote registers.

The reported decrease in memory usage is about 5%.

R=golang-dev, dave, rsc
CC=golang-dev
https://codereview.appspot.com/6902064

Expand All Messages | Collapse All Messages