Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(563)

Issue 690041: new OFDM physical layer model

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Gary Pei
Modified:
10 years, 10 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : separate DSSS from yans and nist. #

Patch Set 3 : this is the right set. #

Total comments: 8

Patch Set 4 : Addressing Nicola's comments #

Patch Set 5 : remove dependency from base class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+681 lines, -176 lines) Patch
A examples/wireless/ofdm-validation.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M examples/wireless/wscript View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
A src/devices/wifi/dsss-error-rate-model.h View 1 chunk +70 lines, -0 lines 0 comments Download
A src/devices/wifi/dsss-error-rate-model.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A src/devices/wifi/nist-error-rate-model.h View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
A src/devices/wifi/nist-error-rate-model.cc View 1 2 3 1 chunk +267 lines, -0 lines 0 comments Download
M src/devices/wifi/wscript View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/devices/wifi/yans-error-rate-model.h View 1 2 3 4 2 chunks +1 line, -29 lines 0 comments Download
M src/devices/wifi/yans-error-rate-model.cc View 2 chunks +4 lines, -145 lines 0 comments Download

Messages

Total messages: 11
Mathieu Lacage
my only comment is that the change of private to protected looks ugly. Other than ...
10 years, 11 months ago (2010-05-19 06:48:04 UTC) #1
Nicola Baldo
I think the contribution is very good and it should be feasible to merge it ...
10 years, 10 months ago (2010-05-26 17:02:35 UTC) #2
Gary Pei
On 2010/05/26 17:02:35, Nicola Baldo wrote: > I think the contribution is very good and ...
10 years, 10 months ago (2010-05-26 23:23:56 UTC) #3
Tom Henderson
> I am fine with duplicating DSSS code. However, it seems better to split > ...
10 years, 10 months ago (2010-05-31 04:32:01 UTC) #4
nbaldo_cttc.es
Hi Tom, On 05/31/2010 06:32 AM, tomh.org@gmail.com wrote: >> I am fine with duplicating DSSS ...
10 years, 10 months ago (2010-06-01 17:21:21 UTC) #5
Gary Pei
On 2010/06/01 17:21:21, nbaldo_cttc.es wrote: > Hi Tom, > > On 05/31/2010 06:32 AM, mailto:tomh.org@gmail.com ...
10 years, 10 months ago (2010-06-08 22:56:32 UTC) #6
Gary Pei
http://codereview.appspot.com/690041/diff/1/5 File src/devices/wifi/nist-error-rate-model.h (right): http://codereview.appspot.com/690041/diff/1/5#newcode28 src/devices/wifi/nist-error-rate-model.h:28: * \brief Model the error rate for different modulations. ...
10 years, 10 months ago (2010-06-09 22:43:36 UTC) #7
Nicola Baldo
I think the patch is ok now. There are only a few trivial issues, once ...
10 years, 10 months ago (2010-06-11 17:02:10 UTC) #8
Gary Pei
http://codereview.appspot.com/690041/diff/12001/13002 File examples/wireless/wscript (left): http://codereview.appspot.com/690041/diff/12001/13002#oldcode43 examples/wireless/wscript:43: On 2010/06/11 17:02:10, Nicola Baldo wrote: > whitespace change? ...
10 years, 10 months ago (2010-06-14 17:50:43 UTC) #9
Tom Henderson
http://codereview.appspot.com/690041/diff/12001/13005 File src/devices/wifi/error-rate-model.h (right): http://codereview.appspot.com/690041/diff/12001/13005#newcode26 src/devices/wifi/error-rate-model.h:26: #include "dsss-error-rate-model.h" On 2010/06/14 17:50:43, Gary Pei wrote: > ...
10 years, 10 months ago (2010-06-14 19:32:14 UTC) #10
Gary Pei
10 years, 10 months ago (2010-06-14 22:20:30 UTC) #11
http://codereview.appspot.com/690041/diff/12001/13005
File src/devices/wifi/error-rate-model.h (right):

http://codereview.appspot.com/690041/diff/12001/13005#newcode26
src/devices/wifi/error-rate-model.h:26: #include "dsss-error-rate-model.h"
On 2010/06/14 19:32:15, Tom Henderson wrote:
> On 2010/06/14 17:50:43, Gary Pei wrote:
> > On 2010/06/11 17:02:10, Nicola Baldo wrote:
> > > this should not be needed
> > 
> > I added here since both yans and nist needed Dsss functions. I can move this
> > statement to yans-error-rate-model.h and nist-error-rate-mode.h if you like
> that
> > way. Please let me know.
> 
> I agree with Nicola; put the dependency on yans and nist but not on this base
> class.
> 

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b