Issue 6891049: code review 6891049: cmd/5g: fix fixedtests/issue4396b.go test failure on arm5

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6891049: code review 6891049: cmd/5g: fix fixedtests/issue4396b.go test failure on arm5 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dfc

Modified:
11 years, 4 months ago

Reviewers:

CC:
remyoudompheng, minux1, rsc, golang-dev

Visibility:
Public.

Description

cmd/5g: fix fixedtests/issue4396b.go test failure on arm5 Add missing file that should have been included in CL 6854063 / 5eac1a2d6fc3

Patch Set 1 #

Patch Set 2 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Patch Set 3 : diff -r 5eac1a2d6fc3 https://code.google.com/p/go #

Patch Set 4 : diff -r e2d1e2a9e609 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/5g/gsubr.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dfc

Hello remyoudompheng@gmail.com, minux.ma@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-12-06 05:16:09 UTC) #1

dfc

*** Submitted as https://code.google.com/p/go/source/detail?r=aef02e2ce485 *** cmd/5g: fix fixedtests/issue4396b.go test failure on arm5 Add missing file ...

11 years, 4 months ago (2012-12-06 05:52:51 UTC) #2

LGTM

Expand All Messages | Collapse All Messages