Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1398)

Issue 6874053: code review 6874053: spec: channel operations are restricted by the channel ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by gri
Modified:
11 years, 4 months ago
Reviewers:
CC:
rsc, r, iant, ken2, golang-dev
Visibility:
Public.

Description

spec: channel operations are restricted by the channel direction Also: - 'for' statements with a range clause do not accept send-only channels - '_, _ = range ch' is not equivalent to "_ = range ch" if ch is a channel (rewriting the latter to the former leads to an invalid range clause). These clarifications document the status quo.

Patch Set 1 #

Patch Set 2 : diff -r 1f3ebf9a7548 https://code.google.com/p/go #

Patch Set 3 : diff -r 1f3ebf9a7548 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 56b8a0a3ca74 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M doc/go_spec.html View 1 5 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 5
gri
Hello rsc@golang.org, r@golang.org, iant@golang.org, ken@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...
11 years, 4 months ago (2012-12-03 19:21:58 UTC) #1
rsc
LGTM https://codereview.appspot.com/6874053/diff/4001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6874053/diff/4001/doc/go_spec.html#newcode3252 doc/go_spec.html:3252: from the channel <code>ch</code>. The channel direction must ...
11 years, 4 months ago (2012-12-03 19:34:34 UTC) #2
gri
Anybody else? - gri https://codereview.appspot.com/6874053/diff/4001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/6874053/diff/4001/doc/go_spec.html#newcode3252 doc/go_spec.html:3252: from the channel <code>ch</code>. The ...
11 years, 4 months ago (2012-12-03 21:43:40 UTC) #3
iant
LGTM
11 years, 4 months ago (2012-12-03 22:17:49 UTC) #4
gri
11 years, 4 months ago (2012-12-03 22:23:48 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=08462805eb2c ***

spec: channel operations are restricted by the channel direction

Also:
- 'for' statements with a range clause do not accept send-only
   channels
- '_, _ = range ch' is not equivalent to "_ = range ch" if ch
   is a channel (rewriting the latter to the former leads to
   an invalid range clause).

These clarifications document the status quo.

R=rsc, r, iant, ken
CC=golang-dev
https://codereview.appspot.com/6874053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b