code review 68730043: all: nacl import round 2

all: nacl import round 2

These previously reviewed CLs are present in this CL.

---
changeset:   18445:436bb084caed
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:50:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-64

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡adg
https://codereview.appspot.com/15760044

---
changeset:   18448:90bd871b5994
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:51:36 2013 -0500
description:
runtime: amd64p32 and Native Client assembly bootstrap

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡khr
https://codereview.appspot.com/15820043

---
changeset:   18449:b011c3dc687e
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:51:58 2013 -0500
description:
math: amd64p32 assembly routines

These routines only manipulate float64 values,
so the amd64 and amd64p32 can share assembly.

The large number of files is symptomatic of a problem
with package path: it is a Go package structured like a C library.
But that will need to wait for another day.

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡bradfitz
https://codereview.appspot.com/15870043

---
changeset:   18450:43234f082eec
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 10:03:19 2013 -0500
description:
syscall: networking for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡rsc
https://codereview.appspot.com/15780043

---
changeset:   18451:9c8d1d890aaa
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 10:03:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-32

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡rsc
https://codereview.appspot.com/15800043

---
changeset:   18452:f90b1dd9228f
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 11:04:09 2013 -0500
description:
runtime: fix frame size for linux/amd64 runtime.raise

R≡rsc
https://codereview.appspot.com/24480043

---
changeset:   18445:436bb084caed
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:50:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-64

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡adg
https://codereview.appspot.com/15760044

---
changeset:   18455:53b06799a938
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 23:29:52 2013 -0500
description:
cmd/gc: add -nolocalimports flag

R≡dsymonds
https://codereview.appspot.com/24990043

---
changeset:   18456:24f64e1eaa8a
user:        Russ Cox <rsc@golang.org>
date:        Tue Nov 12 22:06:29 2013 -0500
description:
runtime: add comments for playback write

R≡adg
https://codereview.appspot.com/25190043

---
changeset:   18457:d1f615bbb6e4
user:        Russ Cox <rsc@golang.org>
date:        Wed Nov 13 17:03:52 2013 -0500
description:
runtime: write only to NaCl stdout, never to NaCl stderr

NaCl writes some other messages on standard error
that we would like to be able to squelch.

R≡adg
https://codereview.appspot.com/26240044

---
changeset:   18458:1f01be1a1dc2
tag:         tip
user:        Russ Cox <rsc@golang.org>
date:        Wed Nov 13 19:45:16 2013 -0500
description:
runtime: remove apparent debugging dreg

Setting timens to 0 turns off fake time.

TBR≡adg
https://codereview.appspot.com/26400043

[rsc, 2014-02-25 21:50:17]

Hello dfc (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2014-02-25 21:53:55]

LGTM



On Tue, Feb 25, 2014 at 1:50 PM, <rsc@golang.org> wrote:

> Reviewers: dfc,
>
> Message:
> Hello dfc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> all: nacl import round 2
>
> These previously reviewed CLs are present in this CL.
>
> ---
> changeset:   18445:436bb084caed
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:50:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-64
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡adg
> https://codereview.appspot.com/15760044
>
> ---
> changeset:   18448:90bd871b5994
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:51:36 2013 -0500
> description:
> runtime: amd64p32 and Native Client assembly bootstrap
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡khr
> https://codereview.appspot.com/15820043
>
> ---
> changeset:   18449:b011c3dc687e
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:51:58 2013 -0500
> description:
> math: amd64p32 assembly routines
>
> These routines only manipulate float64 values,
> so the amd64 and amd64p32 can share assembly.
>
> The large number of files is symptomatic of a problem
> with package path: it is a Go package structured like a C library.
> But that will need to wait for another day.
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡bradfitz
> https://codereview.appspot.com/15870043
>
> ---
> changeset:   18450:43234f082eec
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 10:03:19 2013 -0500
> description:
> syscall: networking for Native Client
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡rsc
> https://codereview.appspot.com/15780043
>
> ---
> changeset:   18451:9c8d1d890aaa
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 10:03:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-32
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡rsc
> https://codereview.appspot.com/15800043
>
> ---
> changeset:   18452:f90b1dd9228f
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 11:04:09 2013 -0500
> description:
> runtime: fix frame size for linux/amd64 runtime.raise
>
> R≡rsc
> https://codereview.appspot.com/24480043
>
> ---
> changeset:   18445:436bb084caed
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:50:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-64
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡adg
> https://codereview.appspot.com/15760044
>
> ---
> changeset:   18455:53b06799a938
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 23:29:52 2013 -0500
> description:
> cmd/gc: add -nolocalimports flag
>
> R≡dsymonds
> https://codereview.appspot.com/24990043
>
> ---
> changeset:   18456:24f64e1eaa8a
> user:        Russ Cox <rsc@golang.org>
> date:        Tue Nov 12 22:06:29 2013 -0500
> description:
> runtime: add comments for playback write
>
> R≡adg
> https://codereview.appspot.com/25190043
>
> ---
> changeset:   18457:d1f615bbb6e4
> user:        Russ Cox <rsc@golang.org>
> date:        Wed Nov 13 17:03:52 2013 -0500
> description:
> runtime: write only to NaCl stdout, never to NaCl stderr
>
> NaCl writes some other messages on standard error
> that we would like to be able to squelch.
>
> R≡adg
> https://codereview.appspot.com/26240044
>
> ---
> changeset:   18458:1f01be1a1dc2
> tag:         tip
> user:        Russ Cox <rsc@golang.org>
> date:        Wed Nov 13 19:45:16 2013 -0500
> description:
> runtime: remove apparent debugging dreg
>
> Setting timens to 0 turns off fake time.
>
> TBR≡adg
> https://codereview.appspot.com/26400043
>
> Please review this at https://codereview.appspot.com/68730043/
>
> Affected files (+3010, -31 lines):
>   M src/cmd/gc/go.h
>   M src/cmd/gc/lex.c
>   A src/pkg/math/abs_amd64p32.s
>   A src/pkg/math/asin_amd64p32.s
>   A src/pkg/math/atan2_amd64p32.s
>   A src/pkg/math/atan_amd64p32.s
>   A src/pkg/math/big/arith_amd64p32.s
>   A src/pkg/math/dim_amd64p32.s
>   A src/pkg/math/exp2_amd64p32.s
>   A src/pkg/math/exp_amd64p32.s
>   A src/pkg/math/expm1_amd64p32.s
>   A src/pkg/math/floor_amd64p32.s
>   A src/pkg/math/frexp_amd64p32.s
>   A src/pkg/math/hypot_amd64p32.s
>   A src/pkg/math/ldexp_amd64p32.s
>   A src/pkg/math/log10_amd64p32.s
>   A src/pkg/math/log1p_amd64p32.s
>   A src/pkg/math/log_amd64p32.s
>   A src/pkg/math/mod_amd64p32.s
>   A src/pkg/math/modf_amd64p32.s
>   A src/pkg/math/remainder_amd64p32.s
>   A src/pkg/math/sin_amd64p32.s
>   A src/pkg/math/sincos_amd64p32.s
>   A src/pkg/math/sqrt_amd64p32.s
>   A src/pkg/math/tan_amd64p32.s
>   M src/pkg/runtime/asm_386.s
>   A src/pkg/runtime/asm_amd64p32.s
>   R src/pkg/runtime/atomic_amd64.c
>   A src/pkg/runtime/atomic_amd64x.c
>   A src/pkg/runtime/cgo/asm_nacl_amd64p32.s
>   A src/pkg/runtime/defs_nacl_386.h
>   A src/pkg/runtime/defs_nacl_amd64p32.h
>   A src/pkg/runtime/memmove_nacl_amd64p32.s
>   A src/pkg/runtime/rt0_nacl_386.s
>   A src/pkg/runtime/rt0_nacl_amd64p32.s
>   M src/pkg/runtime/sys_linux_amd64.s
>   A src/pkg/runtime/sys_nacl_386.s
>   A src/pkg/runtime/sys_nacl_amd64p32.s
>   A src/pkg/syscall/net_nacl.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[bradfitz, 2014-02-25 21:54:56]

Also, do you want me to modify the Linux builder to run this builder as
well?  If so, what's required?  Any NaCl deps?  How does all.bash pass down
to run tests with the new go -exec wrapper?



On Tue, Feb 25, 2014 at 1:50 PM, <rsc@golang.org> wrote:

> Reviewers: dfc,
>
> Message:
> Hello dfc (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> all: nacl import round 2
>
> These previously reviewed CLs are present in this CL.
>
> ---
> changeset:   18445:436bb084caed
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:50:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-64
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡adg
> https://codereview.appspot.com/15760044
>
> ---
> changeset:   18448:90bd871b5994
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:51:36 2013 -0500
> description:
> runtime: amd64p32 and Native Client assembly bootstrap
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡khr
> https://codereview.appspot.com/15820043
>
> ---
> changeset:   18449:b011c3dc687e
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:51:58 2013 -0500
> description:
> math: amd64p32 assembly routines
>
> These routines only manipulate float64 values,
> so the amd64 and amd64p32 can share assembly.
>
> The large number of files is symptomatic of a problem
> with package path: it is a Go package structured like a C library.
> But that will need to wait for another day.
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡bradfitz
> https://codereview.appspot.com/15870043
>
> ---
> changeset:   18450:43234f082eec
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 10:03:19 2013 -0500
> description:
> syscall: networking for Native Client
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡rsc
> https://codereview.appspot.com/15780043
>
> ---
> changeset:   18451:9c8d1d890aaa
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 10:03:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-32
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡rsc
> https://codereview.appspot.com/15800043
>
> ---
> changeset:   18452:f90b1dd9228f
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 11:04:09 2013 -0500
> description:
> runtime: fix frame size for linux/amd64 runtime.raise
>
> R≡rsc
> https://codereview.appspot.com/24480043
>
> ---
> changeset:   18445:436bb084caed
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 09:50:34 2013 -0500
> description:
> runtime: assembly and system calls for Native Client x86-64
>
> See golang.org/s/go13nacl for design overview.
>
> This CL is publicly visible but not CC'ed to golang-dev,
> to avoid distracting from the preparation of the Go 1.2
> release.
>
> This CL and the others will be checked into my rsc-go13nacl
> clone repo for now, and I will send CLs against the main
> repo early in the Go 1.3 development.
>
> R≡adg
> https://codereview.appspot.com/15760044
>
> ---
> changeset:   18455:53b06799a938
> user:        Russ Cox <rsc@golang.org>
> date:        Mon Nov 11 23:29:52 2013 -0500
> description:
> cmd/gc: add -nolocalimports flag
>
> R≡dsymonds
> https://codereview.appspot.com/24990043
>
> ---
> changeset:   18456:24f64e1eaa8a
> user:        Russ Cox <rsc@golang.org>
> date:        Tue Nov 12 22:06:29 2013 -0500
> description:
> runtime: add comments for playback write
>
> R≡adg
> https://codereview.appspot.com/25190043
>
> ---
> changeset:   18457:d1f615bbb6e4
> user:        Russ Cox <rsc@golang.org>
> date:        Wed Nov 13 17:03:52 2013 -0500
> description:
> runtime: write only to NaCl stdout, never to NaCl stderr
>
> NaCl writes some other messages on standard error
> that we would like to be able to squelch.
>
> R≡adg
> https://codereview.appspot.com/26240044
>
> ---
> changeset:   18458:1f01be1a1dc2
> tag:         tip
> user:        Russ Cox <rsc@golang.org>
> date:        Wed Nov 13 19:45:16 2013 -0500
> description:
> runtime: remove apparent debugging dreg
>
> Setting timens to 0 turns off fake time.
>
> TBR≡adg
> https://codereview.appspot.com/26400043
>
> Please review this at https://codereview.appspot.com/68730043/
>
> Affected files (+3010, -31 lines):
>   M src/cmd/gc/go.h
>   M src/cmd/gc/lex.c
>   A src/pkg/math/abs_amd64p32.s
>   A src/pkg/math/asin_amd64p32.s
>   A src/pkg/math/atan2_amd64p32.s
>   A src/pkg/math/atan_amd64p32.s
>   A src/pkg/math/big/arith_amd64p32.s
>   A src/pkg/math/dim_amd64p32.s
>   A src/pkg/math/exp2_amd64p32.s
>   A src/pkg/math/exp_amd64p32.s
>   A src/pkg/math/expm1_amd64p32.s
>   A src/pkg/math/floor_amd64p32.s
>   A src/pkg/math/frexp_amd64p32.s
>   A src/pkg/math/hypot_amd64p32.s
>   A src/pkg/math/ldexp_amd64p32.s
>   A src/pkg/math/log10_amd64p32.s
>   A src/pkg/math/log1p_amd64p32.s
>   A src/pkg/math/log_amd64p32.s
>   A src/pkg/math/mod_amd64p32.s
>   A src/pkg/math/modf_amd64p32.s
>   A src/pkg/math/remainder_amd64p32.s
>   A src/pkg/math/sin_amd64p32.s
>   A src/pkg/math/sincos_amd64p32.s
>   A src/pkg/math/sqrt_amd64p32.s
>   A src/pkg/math/tan_amd64p32.s
>   M src/pkg/runtime/asm_386.s
>   A src/pkg/runtime/asm_amd64p32.s
>   R src/pkg/runtime/atomic_amd64.c
>   A src/pkg/runtime/atomic_amd64x.c
>   A src/pkg/runtime/cgo/asm_nacl_amd64p32.s
>   A src/pkg/runtime/defs_nacl_386.h
>   A src/pkg/runtime/defs_nacl_amd64p32.h
>   A src/pkg/runtime/memmove_nacl_amd64p32.s
>   A src/pkg/runtime/rt0_nacl_386.s
>   A src/pkg/runtime/rt0_nacl_amd64p32.s
>   M src/pkg/runtime/sys_linux_amd64.s
>   A src/pkg/runtime/sys_nacl_386.s
>   A src/pkg/runtime/sys_nacl_amd64p32.s
>   A src/pkg/syscall/net_nacl.go
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[rsc, 2014-02-25 21:59:32]

On Tue, Feb 25, 2014 at 4:54 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:

> Also, do you want me to modify the Linux builder to run this builder as
> well?  If so, what's required?  Any NaCl deps?  How does all.bash pass down
> to run tests with the new go -exec wrapper?
>

Yes, it would be great to modify the Linux builder to do this. A few more
things are required before that will work but we can get it running and
failing.

The only customization on the builder is to put a few things somewhere in
$PATH. Specifically,
grab /home/rsc/nacl_sdk/pepper_29/tools/sel_ldr_* and these scripts (which
must have the given names):

g% cat go_nacl_386_exec
#!/bin/bash

# TODO: Move any $FOO we want to pass through to $NACLENV_FOO.
# TODO: Remove -a chatter, probably by rewriting in C or Go.

export NACLENV_GOARCH=$GOARCH
export NACLENV_GOOS=$GOOS

exec sel_ldr_x86_32 -l /dev/null -e "$@"

g% cat go_nacl_amd64p32_exec
#!/bin/bash

# TODO: Move any $FOO we want to pass through to $NACLENV_FOO.
# TODO: Remove -a chatter, probably by rewriting in C or Go.

export NACLENV_GOARCH=$GOARCH
export NACLENV_GOOS=$GOOS
export NACLENV_GOROOT=/go
export NACLENV_NACLPWD=$(pwd | sed "s;$GOROOT;/go;")

exec sel_ldr_x86_64 -l /dev/null -S -e "$@"

g%

If those exist, then the go command (and therefore all.bash) uses them
automatically.

Thanks.
Russ

[rsc, 2014-02-25 22:00:12]

*** Submitted as https://code.google.com/p/go/source/detail?r=b20943f98e14 ***

all: nacl import round 2

These previously reviewed CLs are present in this CL.

---
changeset:   18445:436bb084caed
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:50:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-64

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡adg
https://codereview.appspot.com/15760044

---
changeset:   18448:90bd871b5994
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:51:36 2013 -0500
description:
runtime: amd64p32 and Native Client assembly bootstrap

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡khr
https://codereview.appspot.com/15820043

---
changeset:   18449:b011c3dc687e
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:51:58 2013 -0500
description:
math: amd64p32 assembly routines

These routines only manipulate float64 values,
so the amd64 and amd64p32 can share assembly.

The large number of files is symptomatic of a problem
with package path: it is a Go package structured like a C library.
But that will need to wait for another day.

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡bradfitz
https://codereview.appspot.com/15870043

---
changeset:   18450:43234f082eec
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 10:03:19 2013 -0500
description:
syscall: networking for Native Client

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡rsc
https://codereview.appspot.com/15780043

---
changeset:   18451:9c8d1d890aaa
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 10:03:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-32

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡rsc
https://codereview.appspot.com/15800043

---
changeset:   18452:f90b1dd9228f
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 11:04:09 2013 -0500
description:
runtime: fix frame size for linux/amd64 runtime.raise

R≡rsc
https://codereview.appspot.com/24480043

---
changeset:   18445:436bb084caed
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 09:50:34 2013 -0500
description:
runtime: assembly and system calls for Native Client x86-64

See golang.org/s/go13nacl for design overview.

This CL is publicly visible but not CC'ed to golang-dev,
to avoid distracting from the preparation of the Go 1.2
release.

This CL and the others will be checked into my rsc-go13nacl
clone repo for now, and I will send CLs against the main
repo early in the Go 1.3 development.

R≡adg
https://codereview.appspot.com/15760044

---
changeset:   18455:53b06799a938
user:        Russ Cox <rsc@golang.org>
date:        Mon Nov 11 23:29:52 2013 -0500
description:
cmd/gc: add -nolocalimports flag

R≡dsymonds
https://codereview.appspot.com/24990043

---
changeset:   18456:24f64e1eaa8a
user:        Russ Cox <rsc@golang.org>
date:        Tue Nov 12 22:06:29 2013 -0500
description:
runtime: add comments for playback write

R≡adg
https://codereview.appspot.com/25190043

---
changeset:   18457:d1f615bbb6e4
user:        Russ Cox <rsc@golang.org>
date:        Wed Nov 13 17:03:52 2013 -0500
description:
runtime: write only to NaCl stdout, never to NaCl stderr

NaCl writes some other messages on standard error
that we would like to be able to squelch.

R≡adg
https://codereview.appspot.com/26240044

---
changeset:   18458:1f01be1a1dc2
tag:         tip
user:        Russ Cox <rsc@golang.org>
date:        Wed Nov 13 19:45:16 2013 -0500
description:
runtime: remove apparent debugging dreg

Setting timens to 0 turns off fake time.

TBR≡adg
https://codereview.appspot.com/26400043

LGTM=bradfitz
R=dave, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/68730043

[iant, 2014-02-25 22:16:52]

https://codereview.appspot.com/68730043/diff/60001/src/cmd/gc/lex.c
File src/cmd/gc/lex.c (right):

https://codereview.appspot.com/68730043/diff/60001/src/cmd/gc/lex.c#newcode304
src/cmd/gc/lex.c:304: flagcount("nolocalimports", "reject local (relative)
imports", &nolocalimports);
New flag should be documented.

[aram, 2014-02-25 23:40:15]

s/2013/2014/

Thanks for working on this.

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_amd64p...
File src/pkg/runtime/asm_amd64p32.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_amd64p...
src/pkg/runtime/asm_amd64p32.s:1: // Copyright 2009 The Go Authors. All rights
reserved.
hg cp.

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/atomic_amd...
File src/pkg/runtime/atomic_amd64x.c (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/atomic_amd...
src/pkg/runtime/atomic_amd64x.c:1: // Copyright 2009 The Go Authors. All rights
reserved.
hg cp.

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/cgo/asm_na...
File src/pkg/runtime/cgo/asm_nacl_amd64p32.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/cgo/asm_na...
src/pkg/runtime/cgo/asm_nacl_amd64p32.s:12: INT $3
TODO?

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/sys_linux_...
File src/pkg/runtime/sys_linux_amd64.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/sys_linux_...
src/pkg/runtime/sys_linux_amd64.s:79: TEXT runtime·raise(SB),NOSPLIT,$0
What's this change?

[rsc, 2014-02-26 15:24:39]

https://codereview.appspot.com/68730043/diff/60001/src/cmd/gc/lex.c
File src/cmd/gc/lex.c (right):

https://codereview.appspot.com/68730043/diff/60001/src/cmd/gc/lex.c#newcode304
src/cmd/gc/lex.c:304: flagcount("nolocalimports", "reject local (relative)
imports", &nolocalimports);
On 2014/02/25 22:16:53, iant wrote:
> New flag should be documented.

Will do in next round.

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/cgo/asm_na...
File src/pkg/runtime/cgo/asm_nacl_amd64p32.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/cgo/asm_na...
src/pkg/runtime/cgo/asm_nacl_amd64p32.s:12: INT $3
On 2014/02/25 23:40:17, aram wrote:
> TODO?

There's no TODO. I don't expect NaCl to ever support cgo.

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/sys_linux_...
File src/pkg/runtime/sys_linux_amd64.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/sys_linux_...
src/pkg/runtime/sys_linux_amd64.s:79: TEXT runtime·raise(SB),NOSPLIT,$0
On 2014/02/25 23:40:17, aram wrote:
> What's this change?

As part of the NaCl alignment requirements, an upcoming change to the toolchain
will diagnose misaligned frame sizes. If you are on a machine with 8-byte words
you should not allocate 12 bytes of stack, because now your stack pointer is
misaligned. The change is correcting the stack size to something 8-byte aligned.
Since the function uses no stack, that something is 0.

[bradfitz, 2014-02-26 18:03:42]

Russ,

The pepper29 directory is 0700.

You want to put those in an CL?  Maybe under misc somewhere?  You can leave
it unsubmitted if you want.





On Tue, Feb 25, 2014 at 1:59 PM, Russ Cox <rsc@golang.org> wrote:

> On Tue, Feb 25, 2014 at 4:54 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote:
>
>> Also, do you want me to modify the Linux builder to run this builder as
>> well?  If so, what's required?  Any NaCl deps?  How does all.bash pass down
>> to run tests with the new go -exec wrapper?
>>
>
> Yes, it would be great to modify the Linux builder to do this. A few more
> things are required before that will work but we can get it running and
> failing.
>
> The only customization on the builder is to put a few things somewhere in
> $PATH. Specifically,
> grab /home/rsc/nacl_sdk/pepper_29/tools/sel_ldr_* and these scripts (which
> must have the given names):
>
> g% cat go_nacl_386_exec
> #!/bin/bash
>
> # TODO: Move any $FOO we want to pass through to $NACLENV_FOO.
> # TODO: Remove -a chatter, probably by rewriting in C or Go.
>
> export NACLENV_GOARCH=$GOARCH
> export NACLENV_GOOS=$GOOS
>
> exec sel_ldr_x86_32 -l /dev/null -e "$@"
>
> g% cat go_nacl_amd64p32_exec
> #!/bin/bash
>
> # TODO: Move any $FOO we want to pass through to $NACLENV_FOO.
> # TODO: Remove -a chatter, probably by rewriting in C or Go.
>
> export NACLENV_GOARCH=$GOARCH
> export NACLENV_GOOS=$GOOS
> export NACLENV_GOROOT=/go
> export NACLENV_NACLPWD=$(pwd | sed "s;$GOROOT;/go;")
>
> exec sel_ldr_x86_64 -l /dev/null -S -e "$@"
>
> g%
>
> If those exist, then the go command (and therefore all.bash) uses them
> automatically.
>
> Thanks.
> Russ
>

[dave_cheney.net, 2014-02-27 00:54:48]

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s
File src/pkg/runtime/asm_386.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s#...
src/pkg/runtime/asm_386.s:352: CALL	AX;				\
Is this part of the nacl specification? Ie, only being able to call thought AX ?

[rsc, 2014-02-27 04:56:17]

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s
File src/pkg/runtime/asm_386.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s#...
src/pkg/runtime/asm_386.s:352: CALL	AX;				\
On 2014/02/27 00:54:49, dfc wrote:
> Is this part of the nacl specification? Ie, only being able to call thought AX
?

It's part of NaCl that you can only do an indirect call using a register.
You cannot specify a memory location.

The actual generated code looks more like

rewrite AX to be safe
CALL AX

so you need something you can scribble on (probably not most memory references).

[dave_cheney.net, 2014-02-27 07:32:18]

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s
File src/pkg/runtime/asm_386.s (right):

https://codereview.appspot.com/68730043/diff/60001/src/pkg/runtime/asm_386.s#...
src/pkg/runtime/asm_386.s:352: CALL	AX;				\
> rewrite AX to be safe
> CALL AX
> 
> so you need something you can scribble on (probably not most memory
references).

Thank you for explaining. I remember reading that amd64p32 required this, it
makes sense that it 386 would have the same convention.